Limit tenacity due to mypy problems #29411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 8.2.0 version of tenacity, implemented a change that breaks mypy checks for clients using `@retry` decorated functions. The issue is tracked in jd/tenacity#389
potiuk
requested review from
kaxil,
Taragolis,
eladkal,
ashb,
dstandish and
jedcunningham
eladkal
approved these changes
Feb 7, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 11, 2023
Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: apache#29411
potiuk
added a commit
that referenced
this pull request
Feb 12, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]>
pierrejeambrun
added
the
changelog:skip
|
|
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 28806a3)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 28806a3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 8.2.0 version of tenacity, implemented a change that breaks mypy checks for clients using
@retrydecorated functions.The issue is tracked in jd/tenacity#389
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.