Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: auth_allow_insecure_global_id_reclaim and mon_warn_on_pool_no_redundancy to false #150

Merged
merged 2 commits into from
Mar 20, 2022
Merged

ceph: auth_allow_insecure_global_id_reclaim and mon_warn_on_pool_no_redundancy to false #150

merged 2 commits into from
Mar 20, 2022

Conversation

tobias-urdin
Copy link
Collaborator

This is for Ceph CVE-2021-20288 to prevent it from
being stuck in HEALTH_WARN.

Issue: #148

@felixonmars
Copy link
Collaborator

I need to use
auth allow insecure global id reclaim = false
instead of
auth expose insecure global id reclaim = false
to mute the warning.

Perhaps there is a typo here?

@tobias-urdin
Set auth_allow_insecure_global_id_reclaim to false
fb376a8 
This is for Ceph CVE-2021-20288 to prevent it from
being stuck in HEALTH_WARN.
@tobias-urdin tobias-urdin changed the title Set auth_expose_insecure_global_id_reclaim to false Set auth_allow_insecure_global_id_reclaim to false Jun 30, 2021
@tobias-urdin
Copy link
Collaborator Author

@felixonmars Yes, thanks! It was a typo on my part.

jd
jd previously approved these changes Jun 30, 2021
View reviewed changes
@tobias-urdin
Copy link
Collaborator Author

@jd can we merge this and issue a new release? need #146 for gnocchi CI as well

@jd
Copy link
Owner

jd commented Jul 1, 2021

Looks like CI is broken here :( @felixonmars what do you want to do?

@tobias-urdin tobias-urdin mentioned this pull request Jul 1, 2021
Closed
@felixonmars
Copy link
Collaborator

Looks like CI is broken here :( @felixonmars what do you want to do?

This is part of the process to fix CI, so I think we should merge it :)

@tobias-urdin
Set mon_warn_on_pool_no_redundancy to false
51f74a3 
This silences the POOL_NO_REDUNDANCY health
check i.e x pool(s) have no replicas
configured.
@mergify mergify bot dismissed jd’s stale review July 2, 2021 10:51

Pull request has been modified.

@tobias-urdin tobias-urdin changed the title Set auth_allow_insecure_global_id_reclaim to false Set auth_allow_insecure_global_id_reclaim and mon_warn_on_pool_no_redundancy to false for Ceph driver Jul 2, 2021
@tobias-urdin
Copy link
Collaborator Author

Another fix for setting mon_warn_on_pool_no_redundancy=false which should fix the last issue with the Ceph driver and fix the CI for you @felixonmars, and for Gnocchi.

@tobias-urdin tobias-urdin changed the title Set auth_allow_insecure_global_id_reclaim and mon_warn_on_pool_no_redundancy to false for Ceph driver ceph: auth_allow_insecure_global_id_reclaim and mon_warn_on_pool_no_redundancy to false Jul 2, 2021
@jd
Copy link
Owner

jd commented Jul 2, 2021

@felixonmars well the CI does not even run now, that's the main problem I'd say.

tobias-urdin added a commit to tobias-urdin/gnocchi that referenced this pull request Jul 4, 2021
@tobias-urdin
Update tox.ini
5a9fbb0 
This adds Python 3.8 and Ubuntu Focal support and
pins pifpaf until [1] is merged and released.

Fixes some warnings on whitelist_externals that
wasn't correct.

[1] jd/pifpaf#150
@tobias-urdin tobias-urdin mentioned this pull request Jul 4, 2021
Merged
tobias-urdin added a commit to tobias-urdin/gnocchi that referenced this pull request Jul 4, 2021
@tobias-urdin
Update tox.ini
2d73949 
This adds Python 3.8 and Ubuntu Focal support and
pins pifpaf until [1] is merged and released.

Fixes some warnings on whitelist_externals that
wasn't correct.

[1] jd/pifpaf#150
@felixonmars
Copy link
Collaborator

@felixonmars well the CI does not even run now, that's the main problem I'd say.

That's weird :/ We should probably consider to switch to GitHub Actions as well.

@tobias-urdin
Copy link
Collaborator Author

need to login to travis ci and select the "free plan" for pifpaf, the jobs will work after that however you only get 1000 credits to run tests with that runs out pretty easily

@jd
Copy link
Owner

jd commented Jul 8, 2021

Yeah I'd suggest moving to GHA…

tobias-urdin added a commit to tobias-urdin/gnocchi that referenced this pull request Jul 15, 2021
@tobias-urdin
Update tox.ini
cc26062 
This adds Python 3.8 and Ubuntu Focal support and
pins pifpaf until [1] is merged and released.

Fixes some warnings on whitelist_externals that
wasn't correct.

[1] jd/pifpaf#150

(cherry picked from commit 2d73949)
@tobias-urdin
Copy link
Collaborator Author

Any progress on the CI part? The commit mentioned above in Gnocchi actually pulls this PR in to make it working, which is merged since a while.

@tobias-urdin tobias-urdin mentioned this pull request Mar 14, 2022
Closed
@felixonmars felixonmars merged commit 38c82de into jd:master Mar 20, 2022
@felixonmars
Copy link
Collaborator

Thanks. Let's merge it and fix the CI later in #149

tobias-urdin added a commit to tobias-urdin/gnocchi that referenced this pull request Mar 21, 2022
@tobias-urdin
Stop using pifpaf fork
01578e7 
Stop using the forked pifpaf that included the Ceph
fix, it's now merged in master for pifpaf upstream
but no new release yet. [1]

[1] jd/pifpaf#150
@tobias-urdin tobias-urdin mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobias-urdin @felixonmars @jd