Migrate CI to Github Actions #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the functional testing that was used in Travis CI. This still leaves the deploy pipeline and fixes the before_deploy script so that python3 is installed so the pypi upload works. It adds the "os" key to the Travis CI config which was a warning. The "user" key in the deploy pipeline is deprecated and should be "username".
If we want to be able to bump s3rver to a newer version we must use the default credentials since that "S3" user can use signing.
This action takes the Dockerfile from ci-tools and updates it to run on Ubuntu 20.04 The action creates the container on each run but after we have migrated away DockerHub to this Dockerfile and archived ci-tools repo we can use the "container" directive on workflows to pull the image from there instead of building it on each run.
Adds the configuration the Gnocchi workflow which moves the docs, pep8 and functional testing jobs to GitHub Actions.
This adds Python 3.8 and Ubuntu Focal support and pins pifpaf until [1] is merged and released. Fixes some warnings on whitelist_externals that wasn't correct. [1] jd/pifpaf#150
This sets the s3rver username and password for the S3 functional testing jobs, required since we have bumped s3rver version.
tobias-urdin
force-pushed
the
feature/fix-migrate-and-update-ci
branch
from
7214224 to
c51a587
Compare
|
@jd see above, all commits should have appropriate comments as well. I tested the workflow on my fork so should be working, but you might need to allow the workflow inside the gnocchi project settings (I don't have permissions I think). |
|
I should also mention that it only migrates the master branch to Github Actions, the stable branches needs to be migrated in a follow up. |
This updates the Mergify config so that it checks the GitHub Actions. We also remove the backport labels for the branches that we recently renamed as EOL.
tobias-urdin
force-pushed
the
feature/fix-migrate-and-update-ci
branch
from
c51a587 to
e47b926
Compare
|
Nice work. Thanks. |
|
GitHub Actions is enabled on this project. |
|
@tobias-urdin That looks good to me, I'm ok to merge it. You can still fix it as you go. |
jd
approved these changes
Jul 5, 2021
chungg
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's is to move away from Travis CI since it's not credit based and we run out of credits after just a few CI runs.
However this also includes a lot of other fixes and changes that benefits the stability and testing of Gnocchi.
The migration plan to move to Github Actions from Travis CI is to (that this PR partly does) continue using Docker but for now build on each job run until we change DockerHub to read Dockerfile from main repo. We can then add "container" directly to our jobs in the workflow and use a hosted container image, and thus retire the ci-tools repo.
This PR will:
This PR has a hard dependency on jd/pifpaf#150 to make Ceph working.
There are some follow up patches that can be done after this which is not covered in this patch.