Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bond: fix carrier-detect and num_unsol_na options #14

Merged

Conversation

cfconrad
Copy link
Collaborator

Problem

  • carrier-detect is use_carrier on Dbus/module option
  • typo in num_unsol_na

Copy link
Owner

@jcronenberg jcronenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcronenberg jcronenberg merged commit 041fbab into jcronenberg:wicked-nm-migration Oct 19, 2023
4 checks passed
cfconrad added a commit to cfconrad/agama that referenced this pull request Dec 6, 2023
…ptions"

This reverts commit 041fbab, reversing
changes made to 60766d5.

Revert "Merge pull request jcronenberg#10 from cfconrad/pr_finalize_bond_options"

This reverts commit fe96673, reversing
changes made to cf1a7b1.

Revert "Merge pull request jcronenberg#1 from cfconrad/impl_bonding"

This reverts commit dabe0c0, reversing
changes made to 518d236.
cfconrad added a commit to cfconrad/agama that referenced this pull request Dec 7, 2023
…ptions"

This reverts commit 041fbab, reversing
changes made to 60766d5.

Revert "Merge pull request jcronenberg#10 from cfconrad/pr_finalize_bond_options"

This reverts commit fe96673, reversing
changes made to cf1a7b1.

Revert "Merge pull request jcronenberg#1 from cfconrad/impl_bonding"

This reverts commit dabe0c0, reversing
changes made to 518d236.
cfconrad added a commit to cfconrad/agama that referenced this pull request Dec 7, 2023
…ptions"

This reverts commit 041fbab, reversing
changes made to 60766d5.

Revert "Merge pull request jcronenberg#10 from cfconrad/pr_finalize_bond_options"

This reverts commit fe96673, reversing
changes made to cf1a7b1.

Revert "Merge pull request jcronenberg#1 from cfconrad/impl_bonding"

This reverts commit dabe0c0, reversing
changes made to 518d236.
jcronenberg pushed a commit that referenced this pull request Nov 7, 2024
This reverts commit 041fbab, reversing
changes made to 60766d5.

Revert "Merge pull request #10 from cfconrad/pr_finalize_bond_options"

This reverts commit fe96673, reversing
changes made to cf1a7b1.

Revert "Merge pull request #1 from cfconrad/impl_bonding"

This reverts commit dabe0c0, reversing
changes made to 518d236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants