bond-options: finalize bonding options #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcronenberg
requested changes
Oct 12, 2023
cfconrad
force-pushed
the
pr_finalize_bond_options
branch
2 times, most recently
from
3bc297d to
2e1ec1b
Compare
cfconrad
force-pushed
the
pr_finalize_bond_options
branch
from
2e1ec1b to
523ebe9
Compare
cfconrad
added a commit
to cfconrad/agama
that referenced
this pull request
Dec 6, 2023
…ptions" This reverts commit 041fbab, reversing changes made to 60766d5. Revert "Merge pull request jcronenberg#10 from cfconrad/pr_finalize_bond_options" This reverts commit fe96673, reversing changes made to cf1a7b1. Revert "Merge pull request jcronenberg#1 from cfconrad/impl_bonding" This reverts commit dabe0c0, reversing changes made to 518d236.
cfconrad
added a commit
to cfconrad/agama
that referenced
this pull request
Dec 7, 2023
…ptions" This reverts commit 041fbab, reversing changes made to 60766d5. Revert "Merge pull request jcronenberg#10 from cfconrad/pr_finalize_bond_options" This reverts commit fe96673, reversing changes made to cf1a7b1. Revert "Merge pull request jcronenberg#1 from cfconrad/impl_bonding" This reverts commit dabe0c0, reversing changes made to 518d236.
cfconrad
added a commit
to cfconrad/agama
that referenced
this pull request
Dec 7, 2023
…ptions" This reverts commit 041fbab, reversing changes made to 60766d5. Revert "Merge pull request jcronenberg#10 from cfconrad/pr_finalize_bond_options" This reverts commit fe96673, reversing changes made to cf1a7b1. Revert "Merge pull request jcronenberg#1 from cfconrad/impl_bonding" This reverts commit dabe0c0, reversing changes made to 518d236.
jcronenberg
pushed a commit
that referenced
this pull request
Nov 7, 2024
This reverts commit 041fbab, reversing changes made to 60766d5. Revert "Merge pull request #10 from cfconrad/pr_finalize_bond_options" This reverts commit fe96673, reversing changes made to cf1a7b1. Revert "Merge pull request #1 from cfconrad/impl_bonding" This reverts commit dabe0c0, reversing changes made to 518d236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finalize the bond option parsing and creation of bond options hash.
The missing peace is the
<address>field, which contains a mac-address. But this need also a change inside the agama model and will come with a separate PR as I will also change the Upstream with it.