Document that port cannot be set in parallel tests

[danile42]

Hi,

as noted in #726, overriding the port does not (always) work with ZIO or Weaver. The reason seems to be that both execute tests in parallel by default.

I documented this in the README and added two specific tests for ZIO.

For Weaver, setting the suite to sequential did not work/help. I tried it as documented here: https://disneystreaming.github.io/weaver-test/docs/parallelism

(BTW, #726 was not my first contribution as mentioned in the release notes for 0.15.1. #526 was my first :) )

Best,
Daniel

[danile42]

Oh, of course this only applies to "inline" style tests. I'll change that later today.

[jbwheatley]

found the fix for weaver:

when we create the server resource in weaver.InlineRequestResponsePactForging, turns out that createServer creates a connection before server.start is called, so we need to suspend it:

Resource.eval(F.delay(createServer)).flatMap { server =>
      Resource.make[F, BaseMockServer] {
        {
          for {
            _ <- validatePactVersion(mockProviderConfig.getPactVersion).liftTo[F]
            _ <- F.delay(server.start())
            _ <- F.delay(server.waitForServer())
          } yield server
        }.onError { case _: Throwable => F.delay(server.stop()) }
      } { s =>
        F.delay(s.stop())
      }
    }

instead of

val server = createServer
Resource.make[F, BaseMockServer] {
  {
        for {
          _ <- validatePactVersion(mockProviderConfig.getPactVersion).liftTo[F]
          _ <- F.delay(server.start())
          _ <- F.delay(server.waitForServer())
        } yield server
      }.onError { case _: Throwable => F.delay(server.stop()) }
    } { s =>
      F.delay(s.stop())
}

once i made that change i could run the weaver tests sequentially as you pointed out

[danile42]

@jbwheatley: I incorporated your Weaver fix, added tests and fixed the documentation.