Replace deprecated URL constructor with URI.toURL in java8 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeljw
force-pushed
the
fix-deprecated-url-constructor-java-8
branch
from
c7129cf
to
6bcb0ef
Compare
gaeljw
approved these changes
Mar 1, 2024
gaeljw
force-pushed
the
fix-deprecated-url-constructor-java-8
branch
from
6bcb0ef
to
a033079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL constructor used in ProviderInfoBuilder has been deprecated as of JDK20, therefore pact4s fails to build using the latest LTS JDK.
This replaces the constructor with
URI.toURL()such that the project can be compiled using JDK versions > 20.(java8-equivalent of PR #527)