🐛 fix(provider-verification): allow empty tags when using pending pacts #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaeljw could you try repushing this to see if the workflow triggers |
|
Look's it's working now. Thanks @jbwheatley |
gaeljw
force-pushed
the
gh520
branch
4 times, most recently
from
fbcc7c1
to
1ea3c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #520
Enabling pending pacts now requires to have either tags or branch set for the provider (but one of them can be undefined).
As the
providerBranchis already set when callingverifyPacts, I didn't add it as a parameter to thePactBrokerWithSelectorsclass like theproviderTagscurrently are. I'm not entirely sure if this matches the desired code architecture or not.I took this opportunity to flag as deprecated all methods referring to the
providerTagsinPactBrokerWithSelectors.