support spray-json #336
Merged
support spray-json #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @danlaudk - could you also update the readme here https://github.com/jbwheatley/pact4s#using-json-bodies |
jbwheatley
reviewed
Nov 29, 2022
build.sbt
Outdated
| libraryDependencies ++= Dependencies.sprayJson, | ||
| Test / parallelExecution := true | ||
| ) | ||
| .dependsOn(shared) |
There was a problem hiding this comment.
issue: this should depend on models, not shared
This comment follows the conventionalcomments.org standard
jbwheatley
reviewed
Nov 29, 2022
|
|
||
| import munit.FunSuite | ||
| import pact4s.sprayjson.implicits.providerStateFormat | ||
| //import spray.json.DefaultJsonProtocol._ |
There was a problem hiding this comment.
nitpick: this can be removed
This comment follows the conventionalcomments.org standard
|
hope i addressed the three comments, big and small (but important 😃). i removed a commit that was a merge of main into this branch. Then I rebased. So the state of the commits originally is only visible here on a copied branch main...danlaudk:pact4s:spray-json-ok-not-squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i can create an example using akka-http that has both play-json and spray-json if acceptable