Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerificationResult.Failed should not cause tests to fail if the pact is pending #51

Closed
kflorence opened this issue Aug 22, 2021 · 0 comments · Fixed by #52
Closed

VerificationResult.Failed should not cause tests to fail if the pact is pending #51

kflorence opened this issue Aug 22, 2021 · 0 comments · Fixed by #52

Comments

@kflorence
Copy link
Contributor

https://github.com/jbwheatley/pact4s/blob/main/shared/src/main/scala/pact4s/PactVerifyResources.scala#L37

This needs to check the status of failed.getPending. If it's true, we should mark the test as skipped instead of failure, since pending pacts should not fail the build.

Originally filed as pact-foundation/pact-jvm#1417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't fail the build if verification fails against a pending pact. kflorence/pact4s
1 participant
@kflorence