Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overrides.yaml and update README (#48) #58

Conversation

vorburger
Copy link
Contributor

@vorburger vorburger commented Feb 13, 2019

see #48

@jmtd
Copy link
Member

jmtd commented Feb 13, 2019

overrides.yaml should be renamed e.g. artefact-overrides.yaml to distinguish it from the other overrides YAML files. All of the overrides files should probably be documented (but that is not a blocker for this PR)

Putting this in these image sources here would be a short-term solution, because the problem is really over in cct_modules, where the artefact definitions are (e.g. https://github.com/jboss-openshift/cct_module/blob/master/jboss/container/jolokia/bash/module.yaml), as @rcernich says in #48 , we probably need community variants of the modules that are pulled in by this image, with correct checksums for the community versions.

@vorburger
Copy link
Contributor Author

overrides.yaml should be renamed e.g. artefact-overrides.yaml

done - better?

Putting this in these image sources here would be a short-term solution

may I open a new issue re. the long-term solution, so that this doesn't hold up merging this PR? #67

@jmtd
Copy link
Member

jmtd commented Jun 29, 2020

This is still an issue for the default cekit build podman, in fact any RHEL7-based image, since the prometheus and jolokia artefacts need to be in the cekit cache to build

CekitError: ("Error copying resource: 'jmx_prometheus_javaagent'. See logs for more info.", CekitError('Artifact jmx_prometheus_javaagent could not be found',))

The issue is gradually going away, the RHEL8 ones should build fine now (RPM-based artefacts), and if we get rid of Jolokia that only leaves Prometheus as the problem for the legacy images.

Perhaps image.yaml should be a RHEL8-based container, not a legacy one.

@jmtd
Copy link
Member

jmtd commented Jan 4, 2021

I'm closing this because the default images don't have the problem this addresses (RHEL8-based) and the RHEL7 ones are getting gradually less and less attention as they are effectively deprecated. I think the thrust of what this is trying to achieve is done (default images build fine in non-special environments) and that gets regularly exercised by GitHub CI too. Thanks for the work!

@jmtd jmtd closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants