Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long term solution to build CE images without overrides #67

Closed
vorburger opened this issue Feb 13, 2019 · 1 comment
Closed

Long term solution to build CE images without overrides #67

vorburger opened this issue Feb 13, 2019 · 1 comment

Comments

@vorburger
Copy link
Contributor

from #48:

Note, using this method, the files in the image will still be named with -redhat- in them, but they will be the community versions (you can verify by expanding the jars and looking at the META-INF/maven/... files).

@jmtd, if we're going to make the default versions of the image.yaml file community oriented, we should probably do the same with the upstream modules (jolokia, hawkular, jmx_exporter). That said, there's probably some work to be done in cekit to help ensure we're using the "proper" file names for these types of resources (e.g. jolokia-jvm-1.5.0-agent.jar instead of jolokia-jvm-1.5.0.redhat-1-agent.jar). @goldmann, @dbecvarik, you're probably interested in this as well, from a cekit perspective.

from #58 :

Putting this in these image sources here would be a short-term solution, because the problem is really over in cct_modules, where the artefact definitions are (e.g. https://github.com/jboss-openshift/cct_module/blob/master/jboss/container/jolokia/bash/module.yaml), as @rcernich says in #48 , we probably need community variants of the modules that are pulled in by this image, with correct checksums for the community versions.

I'm not familiar enough with Cekit to be able to help with that hands-on myself... 😄

Just sayin' to avoid anyone thinking that I'll do this.

@jmtd
Copy link
Member

jmtd commented Oct 24, 2019

We've removed the CentOS image descriptors now, so I'm closing bugs that are specific to those. Watch this space for a (better?) solution for the community story!

@jmtd jmtd closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants