Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BuildTools): Update version to enable updates #36

Closed
wants to merge 1 commit into from

Conversation

corkupine
Copy link

This should enable updates. If there is something undesirable about this, let me know and feel free to close.

@corkupine corkupine changed the title chore: Update package version to enable updates chore(BuildTools): Update version to enable updates Apr 27, 2018
@jberezanski
Copy link
Owner

This, by itself, will have no effect.

Upgrading Visual Studio 2017 is something I have been working on for a long time (#10, this branch) and it is no easy task. I mean, passing the "update" command instead of "install" to the VS installer is trivial, but the hard task is to avoid the many pitfalls, quirks, unexpected behavior and bugs in the VS Installer (#7, #8, #13, #26, #29, #30 and that's not the complete list). That is why the officially released packages are explicitly not doing anything if they detect that Visual Studio is already installed.

Therefore, this pull request would only result in users getting this warning:

WARNING: Visual Studio 2017 Build Tools is already installed. Please use the Visual Studio Installer to modify or repair it.

and, if they did not read it but only looked at the output of clist -lo, they would see the increased package version and mistakenly believe that the Build Tools got updated.

The good news is that I'm nearing completion of the update mechanism. The current working prototype of is available for testing here: visualstudio2017buildtools, visualstudio2017-workload-webbuildtools, visualstudio2017-workload-netcorebuildtools. Once it is complete, I intend to set up an automated mechanism to update the packages (bump versions) whenever a new VS version is released.

So in the light of the above I'm closing this PR. Thank you, however, for motivating me to resume working :)

@jberezanski jberezanski mentioned this pull request Apr 28, 2018
@corkupine
Copy link
Author

Thank you for the detailed explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants