Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vs2017 webbuildtools: installation still running in the background after Choco reports successfull install #13

Open
jberezanski opened this issue May 18, 2017 · 3 comments

Comments

@jberezanski
Copy link
Owner

Reported on Disqus:

Der Meister • an hour ago
Chocolatey says that install was successful, but tasks and targets are not created. I see vs_installer.exe, vs_installerservice.exe and 2 copies of vs_installershell.exe in task manager. The processes consume CPU.

It means that the Choco package does not wait until the actual installation is completed.

@jberezanski
Copy link
Owner Author

Possibly related to #7.

Did this happen on a fresh installation of VS 2017 or did you already have VS 2017 installed for some time and only now decided to add the webbuildtools workload to it?

@dermeister0
Copy link

I had vs_installer on that machine, but it was crashing with node.dll is missing error(https://developercommunity.visualstudio.com/content/problem/24239/cannot-uninstall-microsoft-visual-studio-2017-inst.html).
I copied installer from my developer PC.

May be VS installation is corrupted on the machine.

@jberezanski
Copy link
Owner Author

I think what happened was that when you launched choco install visualstudio2017-workflow-webbuildtools, the VS installer decided it needed to upgrade itself and you got bitten by #7. I'm planning to work around this in two ways: 1) in the install script, detect and wait for other VS installer processes, 2) make the VS installer upgrade operation explicit by putting the logic to do that it in the visualstudio2017-installer package. Stay tuned.

jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
…ore robust

- dispose process handles to avoid the process objects being kept alive
  until the GC runs
- filter out already exited processes to avoid false positives
- if any processes were detected, look again once they finish in order
  to detect any spawned child processes

GitHub-Issue: GH-13
jberezanski added a commit that referenced this issue May 15, 2018
jberezanski added a commit that referenced this issue May 15, 2018
…ected Wait-Process behavior

There have been cases observed where all processes already exited, yet
Wait-Process did not return.

GitHub-Issue: GH-13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants