Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink anchor UI #45

Open
wking opened this issue Dec 2, 2016 · 7 comments
Open

Permalink anchor UI #45

wking opened this issue Dec 2, 2016 · 7 comments

Comments

@wking
Copy link
Collaborator

wking commented Dec 2, 2016

The “navigate by clicking on nodes” idea has come up a few times (#2, #17, #30), but the current implementation is based on dragging the viewBox around. As I mentioned in #17, cards are a bit crowded to make the background that click-to-center target. #30 proposed using the issue title, but I don't think that's particularly intuitive. Stealing a bit of space by following the dep-indicator pattern with an explicit link symbol gives us something like this:

permalink

permalink-collapsed

That starts to look a bit warty, but it is fairly clear. You could also inline the link:

permalink-inline

but having it float inside the card makes it feel like issue information, and less like part of the graph UI.

I'm leaning towards the warty lower-left circle, but would be happy to switch to something else if someone has a cleaner idea :).

@jbenet
Copy link
Owner

jbenet commented Dec 5, 2016

  • in the cases i've shown depviz to others, people have always wanted to navigate to re-center on a card by clicking on it (background or the title. they actually expect the vicinity, and anywhere on the card to work -- except obvious other things: a user picture, comments' number, etc)
  • I (and others) would expect the "link circle" icon to copy a link to depviz centered on that issue to clipboard (but not recenter)
  • I (and others) would expect the github icon to link me to the github.com website version of this task. (not https://github.com)

I strongly think we should:

  • make the whole card a link, to #<depviz-uri> (i.e. to navigate to that one)
    • we can visually signal this by making the card grow a little (border increase by 1-2px?), or be displaced a little (few pixels up, or something). something active that invites the user to click through.
  • make the github icon link to the issue on github
  • the title could be either github or recenter. i can see cases for both.
  • add the link icon which should appear on-hover only, as a way to copy that task's depviz link to clipboard. (but not to navigate/recenter)
  • in all cases, we should tolerate clicking on a small margin around the object. (Eg small author pictures)
  • and can use tooltips to explain where links go (either just alts, or proper bootstrap tooltips.

@jbenet
Copy link
Owner

jbenet commented Dec 5, 2016

(for those with email: updated comment above)

@victorb
Copy link
Collaborator

victorb commented Dec 6, 2016

the title could be either github or recenter. i can see cases for both.

Since there is a dedicated github icon, that would lead to the issue on github, I think that would be confusing. Better to have it recenter the card, like most of the cards interaction area would be doing.

Otherwise, all those changes would be great for Depviz.

For reference, this is how Waffle does it:

selection_004

  1. Clickable area that opens up the issue in Waffle
  2. Clickable area that opens up the issue in Github

Note that the entire card is not clickable, just those three areas. I think that's a mistake.

@Kubuxu
Copy link

Kubuxu commented Dec 6, 2016

Entire cards are draggable which is probably why they are not clickable.

@wking
Copy link
Collaborator Author

wking commented Dec 7, 2016 via email

@victorb
Copy link
Collaborator

victorb commented Dec 7, 2016

@Kubuxu

Entire cards are draggable which is probably why they are not clickable.

No, that would be two different actions, look at how Trello handles having both without problems for example.

Is there an alternative symbol you'd prefer? Maybe ⚓ (U+2693 ANCHOR)? 📌 (U+1F4CC PUSHPIN)? # (U+0023 NUMBER SIGN)?

For copy, there is a establish icon, the holy pasteboard icon, emoji: 📋 unicode: 📋 (U+1F4CB) but would be better to move into proper icons rather than unicode symbols actually. For example: http://www.flaticon.com/search?word=copy

But we can always document it on the landing page if we do need to make the whole card do something

In general, I think we should have the idea that if something becomes so complex without it's actually being real complex (think rocket science), we should make the features and actions easy enough to be self-describing.

@jbenet
Copy link
Owner

jbenet commented Dec 7, 2016

In general, I think we should have the idea that if something becomes so complex without it's actually being real complex (think rocket science), we should make the features and actions easy enough to be self-describing.

agreed.

though i think clicking/touching through on the card is super obvious. it's the first thing people try.

This was referenced Dec 7, 2016
@wking wking added the design label Dec 11, 2016
wking added a commit to wking/depviz that referenced this issue Dec 12, 2016
We currently don't walk dependencies for closed issues, because
they're not related to future progress.  However, the completed-issue
graph is useful for historical context, and Juan is interested in
walking that graph [1].

To make this straightforward, we probably want a way to configure a
hop-depth from a current node.  But the current UI lacks a "current
node" concept and we haven't settled on a UI for selecting nodes
[2,3].  In the meantime, this patch gives users a way for users to
drill down into the dependencies of any closed issue by clicking on
its dependencies indicator.

unwalkedDependencies is currently a bit sloppy, since it should be
false if all of the parents have already been walked.  The current
implementation is good enough for a first pass though.

[1]: jbenet#13 (comment)
[2]: jbenet#30
[3]: jbenet#45
wking added a commit to wking/depviz that referenced this issue Dec 13, 2016
We currently don't walk dependencies for closed issues, because
they're not related to future progress.  However, the completed-issue
graph is useful for historical context, and Juan is interested in
walking that graph [1].

To make this straightforward, we probably want a way to configure a
hop-depth from a current node.  But the current UI lacks a "current
node" concept and we haven't settled on a UI for selecting nodes
[2,3].  In the meantime, this patch gives users a way for users to
drill down into the dependencies of any closed issue by clicking on
its dependencies indicator.

unwalkedDependencies is currently a bit sloppy, since it should be
false if all of the parents have already been walked.  The current
implementation is good enough for a first pass though.

[1]: jbenet#13 (comment)
[2]: jbenet#30
[3]: jbenet#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants