Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/render related nodes #22

Open
wking opened this issue Nov 28, 2016 · 4 comments
Open

Find/render related nodes #22

wking opened this issue Nov 28, 2016 · 4 comments
Labels

Comments

@wking
Copy link
Collaborator

wking commented Nov 28, 2016

We don't do this at the moment (there's a FIXME in the GitHub module). Screenshot for the designed display in #9. Related but (I think?) distinct idea in #15.

@wking wking added the question label Nov 29, 2016
@rht
Copy link

rht commented Jan 9, 2017

Hmmm...Looks like this hasn't been spec-ed / exists only in the viz example. There are two means to put this:

  1. do a regex match on the remaining issues that hasn't been matched by the 'depends on: ...' syntax (e.g. 'CollapsedDepCardView #9' and 'Connected keyword #15' in Find/render related nodes #22 (comment))
  2. vectorize (be it semantic or not) the content of each issue, then construct a similarity matrix. This could be used for issue dedup as well. An existing example I have seen is the related question in SO when posting for a new question (looks like it only matches the question's title instead of the bodies).

(1) can be added directly, but (2) requires either lunrjs for the code to still be able to run on gh-pages or having a full-blown server-side indexing/vectorization.

@wking
Copy link
Collaborator Author

wking commented Jan 9, 2017 via email

@wking wking mentioned this issue Jan 9, 2017
@rht
Copy link

rht commented Jan 10, 2017

I think we want a regexp looking for ‘related to: …’ syntax, because
that will let you declare relations consistently regardless of whether
the relative is on GitHub or not.

For such purpose, an explicit syntax shouldn't be required. The regexp can be augmented to parse gitlab / mailing list thread / atlassian urls.

I'd rather have these be explicitly declared (with ‘related to: …’), since that avoids the need to define matching heuristics.

The matching heuristics is useful for discovery since a human annotator wouldn't be able to constantly comb through the issues (or recall all possibly related past issues) for such.

And I'm not sure how often related issue share a lot of similar strings.

They should both refer to specific objects, vars, error messages, etc. The description should be sufficiently regular, there have been libs used to detect duplicated code.

The reason I've put off related edges so far is that they're
undirected, so you'd either have to document them on each side (in
issue A: ‘related to: #B’, and in issue B ‘related to: #A’) or have a
way to discover backreferences.

This could be done incrementally.
Backref within github has been nailed in #25 (comment).
Cross-linking the issues of github and gitlab would be a separate undertaking, and more doable starting from the gitlab end (https://gitlab.com/search?utf8=%E2%9C%93&search=create_cross_references&group_id=&project_id=13083&search_code=true&repository_ref=bb02141e417ff21deb7707a806a313545bbdd5af).

@wking
Copy link
Collaborator Author

wking commented Jan 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants