Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests on Windows against pip main branch #1736

Merged
merged 4 commits into from
Nov 20, 2022
Merged

Fix CI tests on Windows against pip main branch #1736

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9258c85
Fix CI tests on Windows against pip main branch
atugushev Nov 20, 2022
0081f1f
Test Windows/pipmain
atugushev Nov 20, 2022
75b35e8
Revert "Test Windows/pipmain"
atugushev Nov 20, 2022
9c79310
Merge branch 'master' into pip-main
ssbarnea Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extras =
deps =
pipprevious: pip==22.2.*
piplatest: pip
pipmain: -e git+https://github.com/pypa/pip.git@main#egg=pip
pipmain: https://github.com/pypa/pip/archive/main.zip
Copy link
Member

@ssbarnea ssbarnea Nov 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks interesting! I never knew this was possible.

  • What are the benefits?
  • Will it install newer pip when something new is updated in pip?
  • Will it avoid reinstalling pip when the archive is not changed?
  • Any side-effects on packaging, versioning in particular?

-- Mainly asking because I want to know if I should use the same approach in my projects.

Copy link
Member Author

@atugushev atugushev Nov 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never knew this was possible.

I've seen this mostly in Django projects.

What are the benefits?

Back in the day it was faster than installing from git, especially with submodules. I've tested locally for pip-tools and it's slightly faster.

Will it install newer pip when something new is updated in pip?

I've tested on my own project. It re-installs only if version is updated. I think that's okay for tox where you can always recreate environment using tox --recreate and get latest updates.

Will it avoid reinstalling pip when the archive is not changed?

It won't be reinstalled If version is not updated.

Any side-effects on packaging, versioning in particular?

Not that I know of.

Unfortunately I failed to research why pip fails to re-install itself from git on Windows. It's certainly a bug, but I spent too much time and gave up. I've tried to install the zip and it worked like a charm, hence this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atugushev in your log it's visible that -e and the pip repo URL are parsed as a single argument while they should be separate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it could also be a tox bug too.

setenv =
coverage: PYTEST_ADDOPTS=--strict-markers --doctest-modules --cov --cov-report=term-missing --cov-report=xml {env:PYTEST_ADDOPTS:}
commands_pre =
Expand Down