Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests on Windows against pip main branch #1736

Merged
merged 4 commits into from
Nov 20, 2022

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Nov 20, 2022

Fixes #1671.

Tested on 0081f1f.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added ci Related to continuous integration tasks skip-changelog Avoid listing in changelog labels Nov 20, 2022
@atugushev atugushev marked this pull request as ready for review November 20, 2022 08:59
@atugushev
Copy link
Member Author

atugushev commented Nov 20, 2022

One more thing to address - don't use cache when install pip main zip archive.

UPDATE: perhaps no need to address. I've tested - GitHub invalidates the cache a few moments after committing to the branch. However we could make it explicit to indicate that cache is not welcome in pipmain just in case, for example:

install_command =
    pipmain: python -m pip install --no-cache {opts} {packages}

@atugushev atugushev requested a review from ssbarnea November 20, 2022 16:42
@@ -13,7 +13,7 @@ extras =
deps =
pipprevious: pip==22.2.*
piplatest: pip
pipmain: -e git+https://github.com/pypa/pip.git@main#egg=pip
pipmain: https://github.com/pypa/pip/archive/main.zip
Copy link
Member

@ssbarnea ssbarnea Nov 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks interesting! I never knew this was possible.

  • What are the benefits?
  • Will it install newer pip when something new is updated in pip?
  • Will it avoid reinstalling pip when the archive is not changed?
  • Any side-effects on packaging, versioning in particular?

-- Mainly asking because I want to know if I should use the same approach in my projects.

Copy link
Member Author

@atugushev atugushev Nov 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never knew this was possible.

I've seen this mostly in Django projects.

What are the benefits?

Back in the day it was faster than installing from git, especially with submodules. I've tested locally for pip-tools and it's slightly faster.

Will it install newer pip when something new is updated in pip?

I've tested on my own project. It re-installs only if version is updated. I think that's okay for tox where you can always recreate environment using tox --recreate and get latest updates.

Will it avoid reinstalling pip when the archive is not changed?

It won't be reinstalled If version is not updated.

Any side-effects on packaging, versioning in particular?

Not that I know of.


Unfortunately I failed to research why pip fails to re-install itself from git on Windows. It's certainly a bug, but I spent too much time and gave up. I've tried to install the zip and it worked like a charm, hence this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atugushev in your log it's visible that -e and the pip repo URL are parsed as a single argument while they should be separate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it could also be a tox bug too.

@atugushev atugushev merged commit 6839a64 into jazzband:master Nov 20, 2022
@atugushev atugushev deleted the pip-main branch November 20, 2022 21:49
@atugushev
Copy link
Member Author

Thanks @ssbarnea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration tasks skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on Windows against pip main branch
3 participants