-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI tests on Windows against pip main branch #1736
Conversation
This reverts commit 0081f1f.
One more thing to address - don't use cache when install pip main zip archive. UPDATE: perhaps no need to address. I've tested - GitHub invalidates the cache a few moments after committing to the branch. However we could make it explicit to indicate that cache is not welcome in
|
@@ -13,7 +13,7 @@ extras = | |||
deps = | |||
pipprevious: pip==22.2.* | |||
piplatest: pip | |||
pipmain: -e git+https://github.com/pypa/pip.git@main#egg=pip | |||
pipmain: https://github.com/pypa/pip/archive/main.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks interesting! I never knew this was possible.
- What are the benefits?
- Will it install newer pip when something new is updated in pip?
- Will it avoid reinstalling pip when the archive is not changed?
- Any side-effects on packaging, versioning in particular?
-- Mainly asking because I want to know if I should use the same approach in my projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never knew this was possible.
I've seen this mostly in Django projects.
What are the benefits?
Back in the day it was faster than installing from git, especially with submodules. I've tested locally for pip-tools and it's slightly faster.
Will it install newer pip when something new is updated in pip?
I've tested on my own project. It re-installs only if version is updated. I think that's okay for tox
where you can always recreate environment using tox --recreate
and get latest updates.
Will it avoid reinstalling pip when the archive is not changed?
It won't be reinstalled If version is not updated.
Any side-effects on packaging, versioning in particular?
Not that I know of.
Unfortunately I failed to research why pip fails to re-install itself from git on Windows. It's certainly a bug, but I spent too much time and gave up. I've tried to install the zip and it worked like a charm, hence this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atugushev in your log it's visible that -e
and the pip repo URL are parsed as a single argument while they should be separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it could also be a tox bug too.
Thanks @ssbarnea! |
Fixes #1671.
Tested on 0081f1f.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.