Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup configuration #87

Merged
merged 2 commits into from
May 31, 2022
Merged

Update setup configuration #87

merged 2 commits into from
May 31, 2022

Conversation

kytta
Copy link
Member

@kytta kytta commented May 14, 2022

Both PyPA and setuptools recommend two things:

  • using pyproject.toml to declare the build system (since setuptools is not the only one any more)
  • using setup.cfg (declarative) config file instead of setup.py to reduce boilerplate code

This PR does just that.

kytta added 2 commits May 14, 2022 13:54
The declarative config is recommended to reduce boilerplate code
@kytta kytta added the enhancement Something can be improved label May 14, 2022
@kytta kytta added this to the v2.0.0 milestone May 14, 2022
@kytta kytta requested a review from mbeijen May 14, 2022 12:20
@kytta kytta self-assigned this May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #87 (f2ba5ac) into master (859ebe0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files           4        4           
  Lines         296      296           
  Branches       67       67           
=======================================
  Hits          265      265           
  Misses         15       15           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859ebe0...f2ba5ac. Read the comment docs.

@kytta
Copy link
Member Author

kytta commented May 29, 2022

@mbeijen or @borgstrom, could you please review this PR, so I could merge it without worrying about breaking your preferred setup?

Over all, do you want to be notified about these ‘small’ PRs? Alternatively, I could only worry you when a release PR comes (like the upcoming #86). Please, let me know 😇

@kytta kytta merged commit 7ba6c18 into master May 31, 2022
@kytta kytta deleted the update-setuptools-config branch May 31, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants