-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release of django-simple-menu 2.0.0 #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 89.52% 89.63% +0.10%
==========================================
Files 4 5 +1
Lines 296 299 +3
Branches 67 67
==========================================
+ Hits 265 268 +3
Misses 15 15
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closes #51
This small dependency allows us to reduce latency when importing. It can be removed when we drop Python 3.7 support. See also: https://github.com/pypa/setuptools_scm/#retrieving-package-version-at-runtime
Alright, I think I have finally finished working on everything for the 2.0 release. I think it is important to release the version 2.0.0 without any new features or bug fixes, since we've got bigger problems: The project doesn't have any classifiers, has outdated documentation and dependencies I have changed quite a lot of things, so please, @mbeijen, @borgstrom, take a look and give feedback, if needed 😇 P. S. The Codecov error is there because the diff (which is pretty big because of the renaming) is less covered than the project before. However, the whole project coverage stays the same. I propose we ignore this error on this one occasion (since I am not even sure if it's fixable in our case) |
Hey @mbeijen @borgstrom, I just wanted to remind you about this PR. Since the migration to Jazzband there hasn't been a single release, so v2 is an important milestone to bring the project back on its feet. If you don't have the time, no problem! In this case, I would volunteer to be a project lead on this one. 💁🏻♂️ Just let me know what works well for you. |
thanks for your work and sorry for the delay!! I'll look into your PR and will review & release this week |
I merged and I tagged and I now got a release v0.0.0 -- I guess more work to do |
This is the first major update of
django-simple-menu
, and it finalizes the migration over to Jazzband.simple_menu
(Rename the Python module? #90, Rename module from 'menu' to 'simple_menu' #93)menu
, is deprecated and not recommended. The older package name will be removed in the next major update.simple_menu
directoryOther minor changes