Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release of django-simple-menu 2.0.0 #86

Merged
merged 36 commits into from
Nov 2, 2022
Merged

Conversation

kytta
Copy link
Member

@kytta kytta commented May 14, 2022

This is the first major update of django-simple-menu, and it finalizes the migration over to Jazzband.

⚠️ BREAKING CHANGES

  • dropped support for Python < 3.6
  • dropped support for Django < 3.2
  • renamed the Python package to simple_menu (Rename the Python module? #90, Rename module from 'menu' to 'simple_menu' #93)
    • The usage of the older name, menu, is deprecated and not recommended. The older package name will be removed in the next major update.
    • The Bootstrap templates have been moved to the simple_menu directory

Other minor changes

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #86 (accc532) into master (6a73d6a) will increase coverage by 0.10%.
The diff coverage is 82.68%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   89.52%   89.63%   +0.10%     
==========================================
  Files           4        5       +1     
  Lines         296      299       +3     
  Branches       67       67              
==========================================
+ Hits          265      268       +3     
  Misses         15       15              
  Partials       16       16              
Impacted Files Coverage Δ
simple_menu/templatetags/simple_menu.py 61.70% <61.70%> (ø)
simple_menu/__init__.py 71.42% <71.42%> (ø)
simple_menu/menu.py 90.90% <90.90%> (ø)
simple_menu/templatetags/menu.py 100.00% <100.00%> (ø)
simple_menu/tests/test_menu.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kytta kytta added this to the v2.0.0 milestone May 14, 2022
@kytta kytta mentioned this pull request May 29, 2022
@kytta kytta force-pushed the release/v2.0.0 branch from dedf3c7 to 4e87323 Compare May 31, 2022 16:11
@kytta kytta marked this pull request as ready for review August 26, 2022 22:35
@kytta
Copy link
Member Author

kytta commented Aug 26, 2022

Alright, I think I have finally finished working on everything for the 2.0 release.

I think it is important to release the version 2.0.0 without any new features or bug fixes, since we've got bigger problems: The project doesn't have any classifiers, has outdated documentation and dependencies

I have changed quite a lot of things, so please, @mbeijen, @borgstrom, take a look and give feedback, if needed 😇

P. S. The Codecov error is there because the diff (which is pretty big because of the renaming) is less covered than the project before. However, the whole project coverage stays the same. I propose we ignore this error on this one occasion (since I am not even sure if it's fixable in our case)

@kytta
Copy link
Member Author

kytta commented Nov 2, 2022

Hey @mbeijen @borgstrom, I just wanted to remind you about this PR. Since the migration to Jazzband there hasn't been a single release, so v2 is an important milestone to bring the project back on its feet.

If you don't have the time, no problem! In this case, I would volunteer to be a project lead on this one. 💁🏻‍♂️ Just let me know what works well for you.

@mbeijen
Copy link
Contributor

mbeijen commented Nov 2, 2022

thanks for your work and sorry for the delay!! I'll look into your PR and will review & release this week

@mbeijen mbeijen merged commit 1dc4faa into master Nov 2, 2022
@mbeijen mbeijen deleted the release/v2.0.0 branch November 2, 2022 13:57
@mbeijen
Copy link
Contributor

mbeijen commented Nov 2, 2022

I merged and I tagged and I now got a release v0.0.0 -- I guess more work to do
tbh I'm not sure what is next, I'm not familiar with jazzband builds :sad: do you have advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants