-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base64 encoded responses break unit tests for Python3 #98
Labels
Comments
avelis
added a commit
that referenced
this issue
Jan 20, 2016
Addresses #98 Change set should make all unit tests pass under TravisCI
@avelis sorry, i never use python3.. i made some tests and everything seems fine with your patch, requests are correctly decoded also in p3 try
silky_response.raw_body = base64.b64encode(content)
except TypeError:
silky_response.raw_body = base64.b64encode(content.encode('utf-8')) |
@trik Thanks for your input and suggestions! This will help me move forward with some confidence. |
avelis
added a commit
that referenced
this issue
Jan 20, 2016
Addresses #98 Change set should make all unit tests pass under TravisCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Visible under the last build run on TravisCI(https://travis-ci.org/django-silk/silk/jobs/103436926), the enhancement merged #94 isn't quite Python3 compliant.
This has to due with base64 encoder expecting a byte string and not a string.
Potential solution for https://github.com/django-silk/silk/blob/master/silk/model_factory.py#L240:
The text was updated successfully, but these errors were encountered: