Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binary response bodies #1

Closed
mtford90 opened this issue Jun 6, 2014 · 0 comments
Closed

Support binary response bodies #1

mtford90 opened this issue Jun 6, 2014 · 0 comments

Comments

@mtford90
Copy link
Collaborator

mtford90 commented Jun 6, 2014

Currently binary response bodies such as images are ignored and cannot be displayed in the silk UI. Can probably take advantage of BinaryField to support this

@avelis avelis closed this as completed in 8993d7e Jan 19, 2016
pablodiazgutierrez pushed a commit to appfluence/django-silk that referenced this issue Oct 18, 2020
pablodiazgutierrez pushed a commit to appfluence/django-silk that referenced this issue Oct 18, 2020
Since password checks are incredibly expensive, they should always be paired (AND) with a condition that selects a very small number of records (ideally just one).

However, the Postgres query analyzer isn't capable of properly optimizing the checks so that the crypt calculations are done at the end (on the smallest number of records).

This changes the grammar to enforce users to always AND a password check with another (complex) condition, as well as changing the SQL generator to produce a query that performs the CRYPT checks on the result of the AND term.
pablodiazgutierrez pushed a commit to appfluence/django-silk that referenced this issue Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant