Use safer check in RealDownloadMiddleware #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tari
reviewed
Jul 31, 2024
sevdog
force-pushed
the
fix-realdownload-check
branch
from
bd90c1f to
d385cbb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 85.73% 85.74% +0.01%
==========================================
Files 67 67
Lines 1297 1291 -6
==========================================
- Hits 1112 1107 -5
+ Misses 185 184 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed in #184
RealDownloadMiddlewarefails to correctly process a file which hasnameattribute but noturl, giving a false response.Also this simplify the whole logic of the
RealDownloadMiddleware.is_download_responsemethod.