Use hasattr to check if any of required attribute is present

jazzband · Jul 27, 2023 · bd90c1f · bd90c1f
1 parent 338e171
commit bd90c1f
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/django_downloadview/middlewares.py b/django_downloadview/middlewares.py
@@ -75,14 +75,10 @@ def is_download_response(self, response):
         whose file attribute have either an URL or a file name.
 
         """
-        if super(RealDownloadMiddleware, self).is_download_response(response):
-            try:
-                return response.file.url or response.file.name
-            except AttributeError:
-                return False
-            else:
-                return True
-        return False
+        return (
+            super().is_download_response(response)
+            and (hasattr(response.file, 'url') or hasattr(response.file, 'name'))
+        )
 
 
 class DownloadDispatcher: