-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical operators #82
Conversation
Thanks for the PR @vahmelk99. I'll be reviewing it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not be discouraged by the number of comments. It is normal for this project. Once the suggested changes are implemented I'll give it another round of reviews. Thanks.
1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/task.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/task.md
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
@vahmelk99 also for future PRs the name of the PR should exactly match the title of the article you are translating (see #1). For example the title of this PR should have been |
Should I create a new PR? |
@vahmelk99 nope, just have that noted for future PRs. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vahmelk99 please make sure there are no unnecessary line shifts here and there, also make sure to restore original formatting and new lines where mentioned. Thanks for you contribution.
Please make the requested changes. After it, add a comment "/done". |
…tion.md Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
@bugron thanks for your time. |
/done |
@vahmelk99 thanks for your efforts but unfortunately not all the comments are addressed. GitHub might hide some of them so please make sure everything is in order before we can move on to merging this PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vahmelk99 looks superb! Thanks again for your contribution! I've fixed a few line shifts and svg translation stuff and we're ready to merge this PR.
In the SVG file, I fixed the coordinates of the text, so there were not any overflowed texts. |
@vahmelk99 the thing is that SVG file should not be modified directly, there is a note about that in README.md. A special |
Please check my translation.