Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter rule association when creating NAT Port forward #148

Closed
hisakiyo opened this issue Jul 29, 2021 · 2 comments · Fixed by #544
Closed

Filter rule association when creating NAT Port forward #148

hisakiyo opened this issue Jul 29, 2021 · 2 comments · Fixed by #544
Labels
backlog Issues backlogged for inclusion in future releases documentation Improvements or additions to documentation feature request New feature or request

Comments

@hisakiyo
Copy link

hisakiyo commented Jul 29, 2021 •
edited
Loading

Hi,

Is it possible to set "Filter rule association" parameter to "new" when creating new NAT Port forward ?
https://github.com/jaredhendrickson13/pfsense-api#1-create-nat-port-forwards

Cheers
@jaredhendrickson13 jaredhendrickson13 added documentation Improvements or additions to documentation feature request New feature or request labels Jul 30, 2021
@jaredhendrickson13
Copy link
Owner

Hey!

Currently the API hard sets the associated-rule-id field to pass and does not allow other options. This is primarily due to the complexity of the dependency chain that is required when manipulating port forwards with linked firewall rules. That being said, I'll keep this open as a feature request for future enhancement. Seems this information should also be added to the documentation in a future release.

Thanks!

@jaredhendrickson13 jaredhendrickson13 added the backlog Issues backlogged for inclusion in future releases label Oct 15, 2021
@jaredhendrickson13 jaredhendrickson13 mentioned this issue Feb 16, 2023
Closed
@Harryols
Copy link

Harryols commented Feb 16, 2023 •
edited
Loading

I have made it, how can I add the code?

jaredhendrickson13 added a commit that referenced this issue Aug 18, 2024
@jaredhendrickson13
fix: allow port forward associated-rule-id to be empty string #533 #148
f5e4dd7
@jaredhendrickson13 jaredhendrickson13 linked a pull request Aug 28, 2024 that will close this issue
v2.1.0 Features & Fixes #544
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Issues backlogged for inclusion in future releases documentation Improvements or additions to documentation feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.1.0 Features & Fixes jaredhendrickson13/pfsense-api
3 participants
@Harryols @hisakiyo @jaredhendrickson13