-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make the export-dynamic-plugin
command more generic for backend plugins.
#967
Merged
davidfestal
merged 2 commits into
janus-idp:main
from
davidfestal:make-export-dynamic-more-generic
Nov 22, 2023
Merged
fix: make the export-dynamic-plugin
command more generic for backend plugins.
#967
davidfestal
merged 2 commits into
janus-idp:main
from
davidfestal:make-export-dynamic-more-generic
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for backend plugins. Signed-off-by: David Festal <[email protected]>
davidfestal
force-pushed
the
make-export-dynamic-more-generic
branch
from
November 22, 2023 11:51
e1cf2d7
to
3f5de34
Compare
tumido
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Signed-off-by: David Festal <[email protected]>
davidfestal
force-pushed
the
make-export-dynamic-more-generic
branch
from
November 22, 2023 16:03
4589757
to
504faba
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.4.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Features * make all backend plugins dynamic ([#954](#954)) ([1b4338a](1b4338a)) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * do not fail release on missing dist-dynamic ([#966](#966)) ([647f7b7](647f7b7)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c)) * sync versions in dynamic assets and publish derived packages as additional packages ([#963](#963)) ([7d0a386](7d0a386)) * **tekton:** fix sorting for pipeline run durations ([#952](#952)) ([dc711dd](dc711dd))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.4.6](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.7.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.6.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.6.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.1.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * do not fail release on missing dist-dynamic ([#966](#966)) ([647f7b7](647f7b7)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.4.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [3.5.6](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [3.4.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.3.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.4.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [3.1.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.16.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [1.2.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-22) ### Bug Fixes * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
## [2.0.1](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2023-11-23) ### Features * **cli:** generate plugin specific schema for dynamic plugins ([#912](#912)) ([0c31158](0c31158)) * **dynamic-plugins:** publish dynamic assets for all frontend plugins ([#896](#896)) ([dcfb0ac](dcfb0ac)) * **dynamic-ui:** integrate scalprum with current backstage plugins ([#826](#826)) ([e1fb4ce](e1fb4ce)) * make all backend plugins dynamic ([#954](#954)) ([1b4338a](1b4338a)) * make backend plugins dynamic (first round) ([#910](#910)) ([60523e5](60523e5)) * **ocm:** enable dynamic plugin ([#876](#876)) ([1071eeb](1071eeb)) * **ocm:** export default icon for use in dynamic plugins ([#919](#919)) ([e6dd16d](e6dd16d)) * **rbac:** add role support for policies-csv-file ([#894](#894)) ([7ad4902](7ad4902)) * **rbac:** display administration to authorized users ([#895](#895)) ([70ae509](70ae509)) * **rbac:** implement conditional policies feature. ([#833](#833)) ([3c0675b](3c0675b)) * **rbac:** implement REST method to list all plugin permission policies ([#808](#808)) ([0a17e67](0a17e67)) * **rbac:** implement the concept of roles in rbac ([#867](#867)) ([4d878a2](4d878a2)) * **segment:** expose plugin also as a dynamic ([#955](#955)) ([7b80a40](7b80a40)) * update entity provider schedulers ([#827](#827)) ([19731d1](19731d1)) * update Keycloak plugin for dynamic backend ([#869](#869)) ([a68b38d](a68b38d)) ### Bug Fixes * **aap+3scale+ocm:** don't log sensitive data from errors ([#945](#945)) ([7a5e7b8](7a5e7b8)) * add default 3scale schedule ([#969](#969)) ([11c10b0](11c10b0)) * **cli:** add default scalprum config ([#909](#909)) ([d74fc72](d74fc72)) * **cli:** fix possible dependency conflict ([#950](#950)) ([6c3052e](6c3052e)) * **cli:** share core-app-api package ([#885](#885)) ([09db33c](09db33c)) * **cli:** use react v17 in dynamic plugins build ([#931](#931)) ([b47b10a](b47b10a)) * do not fail release on missing dist-dynamic ([#966](#966)) ([647f7b7](647f7b7)) * **keycloak:** don't log sensitive authentication data ([#938](#938)) ([63d0678](63d0678)) * **keycloak:** embed keycloak admin dependency for dynamic export ([#968](#968)) ([2f005a0](2f005a0)) * **kiali:** use prevState callback ([#874](#874)) ([13a01f7](13a01f7)) * make the `export-dynamic-plugin` command more generic for backend plugins. ([#967](#967)) ([b40c661](b40c661)) * **rbac:** add migration folder to rbac-backend package ([#897](#897)) ([694a9d6](694a9d6)) * **rbac:** add models folder and config.d.ts to package ([#891](#891)) ([406c147](406c147)) * **rbac:** fix service to service requests for RBAC CRUD ([#886](#886)) ([0b72d73](0b72d73)) * **rbac:** handle postgres ssl connection for rbac backend plugin ([#923](#923)) ([deb2026](deb2026)) * **rbac:** use the same Knex version with Backstage ([#929](#929)) ([6923ce0](6923ce0)) * **rbac:** use token manager for catalog requests ([#866](#866)) ([8ad3480](8ad3480)) * **scalprum:** share react-router since various 3rd party plugins use it ([#901](#901)) ([ac0c923](ac0c923)) * **scalprum:** share react-router since various 3rd party plugins use it ([#902](#902)) ([1a548f2](1a548f2)) * segment config schema visibility typo ([#964](#964)) ([836c58c](836c58c)) * share the dynamic entrypoint in ocm backend ([#932](#932)) ([dfddb09](dfddb09)) * sync versions in dynamic assets and publish derived packages as additional packages ([#963](#963)) ([7d0a386](7d0a386)) * **tekton:** fix sorting for pipeline run durations ([#952](#952)) ([dc711dd](dc711dd)) * **tekton:** handle flaky cluster error gracefully ([#887](#887)) ([10ed80e](10ed80e)) * **tekton:** update README and cleanup ([#881](#881)) ([c495515](c495515)) * **tekton:** update tekton version in the documentation ([#958](#958)) ([51cc924](51cc924)) ### Documentation * add contributing guide ([#799](#799)) ([4ce04cd](4ce04cd)) * **servicenow:** add missing ServiceNow config in README ([#926](#926)) ([5b5568f](5b5568f)) * update frontend plugin docs to use EntityLayout instead of EntityPageLayout ([#907](#907)) ([aa91bba](aa91bba))
This was referenced Oct 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
export-dynamic-plugin
command more generic for backend plugins.The goal is to have it usable outside of the restricted Janus context, especially on upstream Backstage backend packages.
Signed-off-by: David Festal [email protected]