Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use react v17 in dynamic plugins build #931

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(cli): use react v17 in dynamic plugins build #931

merged 1 commit into from
Nov 13, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 13, 2023

SSIA

Some upstream plugin reexport has this react v18 flag flaw. Force cli to properly define HAS_REACT_DOM_CLIENT flag in plugins build as well.

@tumido tumido requested a review from a team as a code owner November 13, 2023 12:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tumido tumido merged commit b47b10a into janus-idp:main Nov 13, 2023
7 checks passed
This was referenced Oct 17, 2024
Closed
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tumido @Hyperkid123