forked from jenkinsci/ghprb-plugin
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Farmdawgnation context awareness #217
Merged
Merged
+86
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still waiting on the maintainer to release 1.55.
We don't want to send the context parameter to GitHub at all if no context is specified. Passing in a null to the actual github-api library will prevent it from sending that attribute.
Previously we only had the global configuration. This gives us global and job-specific configuration.
Because git checkout doesn't always do what you want it to. Or to be more correct, you don't always ask it to do the same thing that you think you're asking it to do.
The reasons you should not code late at night: you forget things.
Conflicts: pom.xml src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepository.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/main/resources/org/jenkinsci/plugins/ghprb/GhprbTrigger/config.jelly src/test/java/org/jenkinsci/plugins/ghprb/GhprbRepositoryTest.java
Fixed configuration fixtures for commit status context
… getting all tests passing again.
DavidTanner
added a commit
that referenced
this pull request
Jan 9, 2015
This closes #161 All tests are passing again, and the latest from the other repo are merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.