Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmdawgnation context awareness #217

Merged
merged 19 commits into from
Jan 9, 2015

Conversation

DavidTanner
Copy link
Collaborator

No description provided.

farmdawgnation and others added 19 commits June 20, 2014 18:10
Still waiting on the maintainer to release 1.55.
We don't want to send the context parameter to GitHub at all if no
context is specified. Passing in a null to the actual github-api library
will prevent it from sending that attribute.
Previously we only had the global configuration. This gives us global
and job-specific configuration.
Because git checkout doesn't always do what you want it to. Or to be
more correct, you don't always ask it to do the same thing that you
think you're asking it to do.
The reasons you should not code late at night: you forget things.
Conflicts:
	pom.xml
	src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java
	src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepository.java
	src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java
	src/main/resources/org/jenkinsci/plugins/ghprb/GhprbTrigger/config.jelly
	src/test/java/org/jenkinsci/plugins/ghprb/GhprbRepositoryTest.java
Fixed configuration fixtures for commit status context
DavidTanner added a commit that referenced this pull request Jan 9, 2015
This closes #161 All tests are passing again, and the latest from the other repo are merged in.
@DavidTanner DavidTanner merged commit 1ff3921 into master Jan 9, 2015
@DavidTanner DavidTanner deleted the farmdawgnation-context-awareness branch January 9, 2015 23:58
mmitche referenced this pull request in mmitche/ghprb Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants