Context Awareness: Implement commit status contexts #161
Conversation
|
@farmdawgnation This looks great! Once the dependent plugin is updated, I'll try to get this merged. |
|
Ok, the plugin is bumped but tests didn't pass for me locally when I ran them this morning. Will hopefully take a look at that soon-like. |
|
Would integrating this allow one to run two different Jenkins jobs for each PR, and see the status of both of them? When I try that with the current version, the last one that ran just overwrites the first one (which makes it infeasible / near useless to set-up two jobs). If so, then this would be great to have - the use case is e.g. running a Maven build for a corp. OSS project twice from different jobs - against both a public Maven central as well as against an internal mirror (to double check that's set-up correctly). Anything holding back merging this? I see github-api v1.58 (>1.55 quoted as required above) is available now... and https://developer.github.com/changes/2014-03-27-combined-status-api/ from March mentions "preview period to last 30-60 days", and reading https://developer.github.com/v3/repos/statuses/ makes me thinkg that meanwhile this is part of the GitHub API. So... could this be merged today? |
When @github updates their UI... currently the UI doesn't listen to this. :/ But yes, that's the idea. |
|
Any new on this? Has @github updated their UI to include context yet? |
|
Disappointingly, no. :/ |
|
I also want to just disable updating status, to keep from overwriting another status. |
|
Is this what this PR was waiting for? https://github.com/blog/1935-see-results-from-all-pull-request-status-checks |
|
!!!!!! Yes, yes it is! I'll get this tidied up and ready to ship today. |
|
Ok, I think I picked the correct merge conflict resolution but I've got tests exploding in fiery sparks of doom. A bunch of invocation target exceptions. It looks like the pull request merge test may be the root of them, but I can't find any line numbers from that spec in the stack traces. Any chance someone has an idea of what's up? |
|
Hi, For the tests, I only got failures due to encoding and Github rate limit on the API. And code looked good so I gave it a try, it looks like everything works well here so I just deployed it on our CI server (we really needed this feature !!!) So thanks for the work! |
|
Awesome! I'm going to see if I can get all greens on my end and deploy it to mine as well. Will post back here after I do! |
|
Actually @farmdawgnation there was others errors but I have found where tests were breaking for those ones, now the build is marked as success, I send you a PR to your fork ;) |
|
!! |
Fixed configuration fixtures for commit status context
farmdawgnation
changed the title
|
I'm still seeing a bunch of NPE's when I try to run tests, but if that's only me then so be it. I think this is ready to go. |
|
Any news on this? Would be great to have this! |
|
We're using this at my office and it's been working great! Ready to see it in the main plugin! :) |
|
It would be really great to have this soon. Thanks for the implementation @farmdawgnation ! |
|
@valdisrigdon Can we get some attn here? :) |
|
Isn't the primary repo on https://github.com/jenkinsci/ghprb-plugin now? I see @DavidTanner made a commit there one day ago. |
|
Well it would have been nice for someone to tell us. heh |
|
I will check in on this tonight/tomorrow. Sorry, I changed roles so I am not as active with jenkins. |
This closes #161 All tests are passing again, and the latest from the other repo are merged in.
Back in March, Github released the Combined status API. As it nears the end of its developer preview period, the organization I work for has found need to start leveraging them. From what I can tell, this is working as intended. But GitHub doesn't seem to be reflecting these in their UI yet. 😢
That said, I think this could still be useful for teams that want it so I decided to go ahead and open the pull request. This PR can't be merged until release 1.55 of the github-api jenkins plugin is out the door. The java dependency itself has been released, but it looks like when they tried to release the plugin things didn't go as planned? I've emailed the author about it, and am still waiting on a response.
So, things we need:
closes #155