Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tags under the Manage tab #2

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Added tags under the Manage tab #2

merged 1 commit into from
Feb 3, 2019

Conversation

janetye
Copy link
Owner

@janetye janetye commented Jan 18, 2019

Addresses apache#3821 (Pt 2)

  • Added Tags under the Manage tab
  • Added an fonts awesome icon for tags

- Added Tags under the Manage tab
- Added an fonts awesome icon for tags
@janetye janetye requested a review from spbail January 18, 2019 16:22
appbuilder.add_view(
TagModelView,
'Tags',
label=__('Tags'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be two underscores?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like they use dunder for the labels

@janetye janetye merged commit 70709f8 into master Feb 3, 2019
@spbail
Copy link

spbail commented Feb 3, 2019

I get notifications now! Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants