Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to tag dashboards #3821

Closed
mnemalur opened this issue Nov 9, 2017 · 20 comments
Closed

Allow users to tag dashboards #3821

mnemalur opened this issue Nov 9, 2017 · 20 comments

Comments

@mnemalur
Copy link

mnemalur commented Nov 9, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • [ Y] I have checked the superset logs for python stacktraces and included it here as text if any
  • [ Y] I have reproduced the issue with at least the latest released version of superset
  • [ Y] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.19

Expected results

I Would love to find a way to group multiple dashboards into logical groups and restrict access to each group.
Like Folder A -- > Dashboard1, Dashboard2, Folder B -- > Dashboard3, Dashboard4 etc..
When we list all Dashboards on the screen once you have too many , u need to use the filter criteria,.
Instead can we group them.

Actual results

Steps to reproduce

@rumbin
Copy link
Contributor

rumbin commented Nov 10, 2017

I second that. It would be useful to provide folders (or tags?!) for, e.g., departments or other categorical criteria.

@xrmx
Copy link
Contributor

xrmx commented Nov 10, 2017

I use the datasources as a way to distinguish between departments / whatever.

@graceguo-supercat
Copy link

We will provide Tabs for dashboard, currently under design and discussion.

@bbs2009
Copy link

bbs2009 commented Nov 13, 2017

It would be nice to do the slices too

.(provide folders (or tags?!))

@alanmcruickshank
Copy link
Contributor

@graceguo-supercat

I love the idea of tagging, rather than tabs or folders. That would allow a single dashboard to appear in multiple groups.

If we do go down that route - I'd love to be able to set a specific tag to control the dashboards available on the welcome page. That way we can direct people to a specific curated set of dashboard as a starting point.

@rpwils
Copy link

rpwils commented Nov 22, 2017

I agree this is a nice feature, we want to role this out to 2000 people and the more we can group the better.
Has anyone done any more design on limiting view of slices and dashboards besides the default with data sources? On think i was thinking if we get the feature in this issue, maybe we can get by with having a simple version of the privs. with a private flag. By default a private flag would limit the dashboard to just the user who created it. Might need to carry that down to slices. Should I start a thread on that?

@luciuschina
Copy link

Group the dashboards into Folders,I like this feature.

@mistercrunch
Copy link
Member

I also prefer tagging over groups

@mistercrunch mistercrunch changed the title Group the dashboards into Folders when there are too many to view. Allow users to tag dashboards Nov 30, 2017
@mistercrunch
Copy link
Member

Few notes:

  • tags should be create as a many to many relationship in the db, eventually can be reused to tag slices using the same tag namespace but that lower pri
  • most of the UI stuff (filtered Dashboard list view, tag creation / association) can be done automagically in FAB by just setting the model and modelviews properly
  • tags should be surfaced right of the dashboard title ("label-default"), with click navigation taking users to filtered dashboard list

@alanmcruickshank
Copy link
Contributor

To summarise some of the things people have mentioned, and some things which are still a bit less defined.

General Concensus Summary

  • Tags or Folders?: Tags
    • Many to many relationships. i.e. one tag can be applied to many dashboards, one dashboard may have many tags.
  • Same namespace to tag both dashboards and slices. By clicking on a tag you can see both the dashboards and slices associated with that tag. Effectively filtering the list
  • Tags will be shown as coloured tabs just to the right of the dashboard title. Bootstrap badge style

Open Questions

  • Some people have mentioned tags which would confer some special functionality, like a private tag which means only you can see it, or a featured tag which would automatically bring things to the front of a list - or put them onto the front page. Is this something where there are sufficiently few use cases that we should have a few "magic" tags which have special hardcoded features - or is this something that should be configurable.
    • as a followup, are there certain tags which should be automatically implemented as a result, i.e. bundled into a standard setup when calling superset init.
    • should some tags be automatically applied to new slices - e.g. a slice is automatically tagged as private until explicitly shared? Perhaps a dashboard should be automatically private until tagged with the shared tag - although my preference is to default to shared rather than default to private.
  • Should tags all be the same colour (grey/superset-teal) - or is colour something that should be configurable for a given tag?
  • Should tags be visible on the dashboards themselves? Or are they something that is just shown in list views etc...? Likewise should tags for slices be shown on the explore view?

What do you guys reckon? Anything else I've missed?
@mistercrunch @xrmx @graceguo-supercat @luciuschina @rpwils @rumbin @bbs2009 @mnemalur

@rpwils
Copy link

rpwils commented Dec 5, 2017 via email

@rpwils
Copy link

rpwils commented Jan 4, 2018

hi @alanmcruickshank just checking in to see if you have been able to make progress?

thanks!

@tcollier1975
Copy link

Agreed! @alanmcruickshank logical groupings of dashboards would be an extremely valuable functionality to have. Our list of dashboards are getting a little out of hand.

@rpwils
Copy link

rpwils commented Jan 21, 2018

@mistercrunch
Looking at taking a stab at this as we could really use it... from you comments above. does this work for you on the db side. 3 simple tables

tags
id
tag_name
tag_color
….

dashboard_tags
id
dashboard_id
tag_id

slices_tags
id
slice_id
tag_id

@alanmcruickshank
Copy link
Contributor

@rpwils - I've not managed to make a stab at this, been completely snowed with a couple of other things. I like your suggested table schema. Having a separate id primary key column in dashboard_tags and slices_tags is in line with the format of dashboard_slices rather than having a two column table with a composite primary key.

The existing table slice_user suggests that we should call the tag table slice_tag rather than slices_tags.

@mcdavey17
Copy link

And allowing permissioning based on tags would be a good solution to #1799.

@mistercrunch
Copy link
Member

Well @mcdavey17 that may mean seriously restricting who can tag dashboards though.

@alanmcruickshank
Copy link
Contributor

alanmcruickshank commented Feb 19, 2018 via email

janetye pushed a commit to janetye/incubator-superset that referenced this issue Dec 14, 2018
Addresses apache#3821
- Created a Tags object
- Added a Tags field to the dashboard view
- Showed the tags field in search, filter, and edit fields
- Added Tags database migration
@IssueHuntBot
Copy link

@rororofff has funded $15.00 to this issue.


@stale
Copy link

stale bot commented May 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 28, 2019
@stale stale bot closed this as completed Jun 4, 2019
@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
@junlincc junlincc reopened this Nov 19, 2021
@stale stale bot removed the inactive Inactive for >= 30 days label Nov 19, 2021
@amitmiran137 amitmiran137 removed the good first issue Good first issues for new contributors label Feb 7, 2022
@apache apache locked and limited conversation to collaborators Mar 16, 2022
@graceguo-supercat graceguo-supercat converted this issue into discussion #19174 Mar 16, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests