This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Added an until property when calling Ember.deprecate
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es deprecation warnings seen with Ember 2.8.
|
+1 |
|
Actually just to clarify, this error only happens with master, not 4.2.2. But this should be merged before cutting any new releases and it is backwards compat. |
|
@jamesarosen Thanks for the create turnaround time! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves deprecation warnings seen with Ember >= 2.2 and
ember-i18n >= 4.2.2ember-i18n > 4.2.2.This deprecate was originally added via #381. In that PR it was stated the deprecation was targeted at 5.x. So I made the
untilvalue reflect that (see diff).