This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Reserve locale and htmlSafe attributes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
force-pushed
the
reserve-locale-htmlSafe
branch
from
b1835da to
1db3ff2
Compare
| service.t('not.yet.translated', { locale: true }); | ||
| assert.equal(deprecations, 2); | ||
|
|
||
| service.t('not.yet.translated'); |
There was a problem hiding this comment.
Maybe service.t('not.yet.translated', { some: 'other key' })
There was a problem hiding this comment.
Sounds good, I'll add one that includes interpolation
There was a problem hiding this comment.
All done, it's on line 63 to catch both w/ and w/o data attribute.
jasonmit
force-pushed
the
reserve-locale-htmlSafe
branch
from
1db3ff2 to
a7bcf7c
Compare
|
+1 |
|
@jamesarosen once merged I'll start on the second part of what we discussed, supporting inlining a locale when looking up a translation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussion over slack /cc @jamesarosen
This is for handling deprecations ahead of 5.x
Loosely related to #377