Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jidea-191 Add small delay to parameter option tooltips #88

Merged
merged 2 commits into from
Nov 11, 2024
Merged

jidea-191 Add small delay to parameter option tooltips #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6542f4
Add small delay to parameter option tooltips
david-mears-2 Nov 4, 2024
0ad75e7
Fix package-lock.json version of app
david-mears-2 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions assets/scss/_theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ body {
opacity: 0.5;
}

.tooltip {
max-width: $tooltip-max-width;
}

// Limit modal dialog width by screen width. Override modal default max-width when screen would have been narrower than modal.
// Media queries can't use dynamic variables, but the calculation to get 532px was: calc(var(--cui-modal-width) + 2 * var(--cui-modal-padding));
@media (max-width: 532px) {
Expand Down Expand Up @@ -180,4 +176,4 @@ body {
.vue-select .menu-option:hover ~ .menu-option:not(.selected) // select subsequent siblings to hovered, if not selected
{
background-color: var(--vs-option-bg)!important;
}
}
2 changes: 1 addition & 1 deletion assets/scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ $table-bg: transparent;

// fonts
$font-size-base: 1rem; // Assumes the browser default, typically `16px`
$font-size-sm: $font-size-base * .875;
$font-size-sm: $font-size-base * .875;
1 change: 1 addition & 0 deletions components/ParameterForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
:key="option.id"
:content="option.description"
placement="top"
:delay="100"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite short, but seems fine. It does mean that you get the same delay on hide. I tried using a structured delay i..e :delay="{'show': 100, 'hide': 5}" but found that gave some weird effects, like tooltips hanging around when they should have been removed or even appearing at the start of the DOM!

>
<template #toggler="{ togglerId, on }">
<div
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "daedalus-web-app",
"type": "module",
"version": "0.1.0",
"version": "0.1.1",
"private": true,
"engines": {
"node": ">=20"
Expand Down