jidea-191 Add small delay to parameter option tooltips #88
Conversation
This is to make it slightly less visually chaotic when quickly mousing through different options - avoids obscuring options when you are trying to select them
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 1.62% 1.62%
=======================================
Files 54 54
Lines 146163 146164 +1
Branches 306 306
=======================================
+ Hits 2379 2380 +1
Misses 143768 143768
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
Please review at your leisure! |
|
Added a ticket for this: https://mrc-ide.myjetbrains.com/youtrack/issue/JIDEA-191/Add-delay-to-parameter-option-tooltips |
EmmaLRussell
changed the title
There was a problem hiding this comment.
It's annoying that the None option is getting placed on the right since the tooltip width was increased. Could slim it down to fit it above again to avoid the obscuring problem? But this is fine too.
Could you align the package version numbers before merging please?
package-lock.json
Outdated
| "version": "0.1.0", | ||
| "lockfileVersion": 3, | ||
| "requires": true, | ||
| "packages": { | ||
| "": { | ||
| "name": "daedalus-web-app", | ||
| "version": "0.0.2", | ||
| "version": "0.1.0", |
There was a problem hiding this comment.
This looks a bit iffy. We should have updated the package-lock when we updated the version, but it should be 0.1.1 by now - or 0.1.2 if you want to update for this change.
| @@ -30,6 +30,7 @@ | |||
| :key="option.id" | |||
| :content="option.description" | |||
| placement="top" | |||
| :delay="100" | |||
There was a problem hiding this comment.
This is quite short, but seems fine. It does mean that you get the same delay on hide. I tried using a structured delay i..e :delay="{'show': 100, 'hide': 5}" but found that gave some weird effects, like tooltips hanging around when they should have been removed or even appearing at the start of the DOM!
I agree. But I think making all tooltips narrow enough to prevent this (175px) results in them being too narrow and that's worse overall. |
This is to make it slightly less visually chaotic when quickly mousing through different options - avoids obscuring options when you are trying to select them