Skip to content

Commit

Permalink
7.x only REST specification fixes (elastic#56736)
Browse files Browse the repository at this point in the history
Fixes for the REST specification specific to 7.x

* remove ignore "cat.thread_pool.json" and add the "" as valid option. elastic#55984 deprecated this field since it these params here have no effect on this specific API
* remove ignore "indices.put_mapping.json" by adding the required / in the path to pass validation.
  • Loading branch information
jakelandis authored May 26, 2020
1 parent 74b2c8a commit 920677a
Showing 4 changed files with 3 additions and 8 deletions.
5 changes: 0 additions & 5 deletions rest-api-spec/build.gradle
Original file line number Diff line number Diff line change
@@ -10,8 +10,3 @@ artifacts {
restSpecs(new File(projectDir, "src/main/resources/rest-api-spec/api"))
restTests(new File(projectDir, "src/main/resources/rest-api-spec/test"))
}

validateRestSpec {
ignore "cat.thread_pool.json"
ignore "indices.put_mapping.json"
}
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@
"p"
],
"deprecated":{
"version":"7.8.0",
"version":"7.7.0",
"description":"Setting this value has no effect and will be removed from the specification."
}
},
Original file line number Diff line number Diff line change
@@ -127,7 +127,7 @@
}
},
{
"path":"{index}/_mappings",
"path":"/{index}/_mappings",
"methods":[
"PUT",
"POST"
2 changes: 1 addition & 1 deletion rest-api-spec/src/main/resources/schema.json
Original file line number Diff line number Diff line change
@@ -201,7 +201,7 @@
"type": "array",
"items": {
"type": "string",
"pattern": "^[a-zA-Z_]+$"
"pattern": "^\\d*|[a-zA-Z_]+$"
},
"title": "Valid options when type is an enum"
},

0 comments on commit 920677a

Please sign in to comment.