deprecrate size from cat.thread_pool in json spec #55984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
>non-issue
:Data Management/CAT APIs
|
Pinging @elastic/es-core-features (:Core/Features/CAT APIs) |
elasticmachine
added
the
Team:Data Management
russcam
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
LGTM @jakelandis 👍
Should the time param be added to this PR too, based on #55736?
|
Thanks @russcam - the |
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 30, 2020
jakelandis
added a commit
that referenced
this pull request
Apr 30, 2020
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
May 14, 2020
jakelandis
added a commit
that referenced
this pull request
May 26, 2020
Fixes for the REST specification specific to 7.x * remove ignore "cat.thread_pool.json" and add the "" as valid option. #55984 deprecated this field since it these params here have no effect on this specific API * remove ignore "indices.put_mapping.json" by adding the required / in the path to pass validation.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
May 26, 2020
Fixes for the REST specification specific to 7.x * remove ignore "cat.thread_pool.json" and add the "" as valid option. elastic#55984 deprecated this field since it these params here have no effect on this specific API * remove ignore "indices.put_mapping.json" by adding the required / in the path to pass validation.
jakelandis
added a commit
that referenced
this pull request
May 26, 2020
) The rest spec and documentation for _cat/threadpool supports a "size" parameter. However, the "size" parameter will have no impact since there are no values of type "SizeValue" of the return value of this _cat api. This commit deprecates this from JSON spec and will be removed in a followup. Note - this only impacts the JSON spec since all cat APIs support the same set of parameters, even if the specific call is not impacted by the param.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
May 26, 2020
Fixes for the REST specification specific to 7.x * remove ignore "cat.thread_pool.json" and add the "" as valid option. elastic#55984 deprecated this field since it these params here have no effect on this specific API * remove ignore "indices.put_mapping.json" by adding the required / in the path to pass validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest spec and documentation for _cat/threadpool supports a "size" parameter.
However, the "size" parameter will have no impact since there are no values
of type "SizeValue" of the return value of this _cat api.
This commit deprecates this from JSON spec and will be removed in a followup.
Note - this only impacts the JSON spec since all cat APIs support the same set
of parameters, even if the specific call is not impacted by the param.