-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta Data 1.0 #737
Jakarta Data 1.0 #737
Conversation
✅ Deploy Preview for jakartaee-specifications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello all, EMO REVIEW CHECKLIST@Emily-Jiang while evaluating your project IP I've found a couple of issues: Hopefully, they will be solved soon. EDP Review status: COMPLETED EMO review checklistPMI record: https://projects.eclipse.org/projects/ee4j.data/reviews/1.0-release-review EF Specification Process
Intellectual Property Management
Open Source Rules of Engagement
General:
Things to check:
Branding and Trademarks
Things to check:
Legal Documentation
Recommended files:
See examples for Security file and Code of Conduct. Required elements:
Recommended elements:
Metadata (PMI)
|
Mentor Spec Review Checklist
|
Mentor review comments:
The addendum doc uses the name jakarta-method-name-query-1.0.pdf. Please update to jakarta-data-addendum-1.0.pdf and .html or merge the content into the parent doc. |
In the PR template, there are a couple of TODOs, which made this PR incomplete. If it is required, please provide them. If not, please delete the TODOs @KyleAure |
@Emily-Jiang I've opened a PR against data to fix the TCK-Distribution license to version 1.1 here: jakartaee/data#745 The link you provided to the license document has a copy of the license in HTML and AsciiDoc versions. I replaced license.txt with license.adoc which should be consistent with the requirements. |
Minor comment on TCK user guide: In the section 6, in the table, there are |
@Emily-Jiang I have created an issue to do this: jakartaee/data#746 |
We discussed on the Jakarta EE spec committee call. From now on, all new spec releases need to use the v1.1. |
@Emily-Jiang From now on... does that mean EE 11 or EE 12? |
I double checked the minutes from Jakarta EE Spec Committee meetings. Here is the latest statement regarding the license version requirement. Using TCK License v1.1 is encouraged but not mandatory. Since updating the tck jar causes CCRs to be redone, I am happy for this project to use v1.0 for this release. Any future releases must update the license to v1.1. |
It is okay to have it corrected in the next release as you cannot easily release another TCK jar without a big delay. |
On ballot completion, the specification committee mentor:
|
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
Instructions MAY be by reference.
Generated IP Log- https://jakarta.oss.sonatype.org/content/repositories/jakartadata-1023/
- Staged: https://download.eclipse.org/ee4j/data/jakartaee11/staged/eftl/
- Promoted: https://download.eclipse.org/ee4j/data/jakartaee11/promoted/eftl/
- Persistence (standalone): [Certification]: Hibernate 6.6.0.X Jakarta Data 1.0 data#714
- Persistence (platform) : [Certification]: Compatibility certification request for Open Liberty 24.0.0.6-beta for Jakarta Data 1.0 (of Jakarta EE 11) data#741
If desired, an optional second PR can be created to contain just the JavaDoc in the
apidocs
directory.Note: If any item does not apply, check it and mark N/A below it.