Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TCK license #745

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update TCK license #745

merged 2 commits into from
Jun 7, 2024

Conversation

KyleAure
Copy link
Contributor

Missed updating the TCK License in the last round of mentor reviews.

@KyleAure KyleAure requested review from Emily-Jiang and mswatosh May 23, 2024 13:29
@KyleAure KyleAure self-assigned this May 23, 2024
mswatosh
mswatosh reviewed May 23, 2024
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assembly.xml should be updated to point to the adoc instead of txt:

data/tck-dist/src/main/assembly/assembly.xml

Line 31 in 28debff

<source>src/main/EFTL.txt</source>

@KyleAure KyleAure mentioned this pull request May 23, 2024
Merged
14 tasks
@KyleAure KyleAure added this to the 1.0.1 milestone May 23, 2024
@KyleAure KyleAure mentioned this pull request Jun 7, 2024
Closed
25 tasks
@KyleAure KyleAure merged commit 5241665 into jakartaee:main Jun 7, 2024
3 checks passed
@KyleAure KyleAure deleted the update-tck-license branch June 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswatosh mswatosh mswatosh approved these changes

@Emily-Jiang Emily-Jiang Awaiting requested review from Emily-Jiang

Assignees

@KyleAure KyleAure

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleAure @mswatosh