-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement N-1 support policy for Go versions #4653
Comments
Hi @yurishkuro , in task 1 : "verifies that all our build scripts are using the same Go version N" 1.how do i find those build scripts from such large code base ? |
hey @yurishkuro what is the estimated/expected time limit |
Hey @yurishkuro as I was trying to setup the project I encountered this issue |
Continuing this, I faced issue in running |
If we upgrade golangci-lint, we'll be subject to the problem described in: golangci/golangci-lint#3906, where a large number of depguard lint errors appear. We'll need to understand why those linting errors are appearing and what actions need to be taken to address them, or if it's better to stick with the current version until that problem is ironed out in a later version. FWIW, I didn't have any issues installing 1.52.1. |
## Which problem is this PR solving? Resolves #4653 ## Description of the changes - Current files tracked are go.mod, all yml files in ./github/workflows/ and ./docker/Makefile. If there are any more build scripts to track, I would be happy to update the PR. - Added scripts/check-go-version.sh to verify that all our build scripts are using the same Go version N, but go.mod is N-1 and fail if not, with an error message and the source files along with their respective versions. - Added scripts/update-go-version.sh to update those scripts to latest version, to make these upgrades easier in the future. Also bumps go.mod to version N-1. - Updated README explaining the support policy. ## How was this change tested? - I have tested the changes locally by modifying go versions ![Screenshot_20230813_120937](https://github.com/jaegertracing/jaeger/assets/140232061/bb4d9e18-22b5-4fcc-9c2b-d374bec0bc4a) ![Screenshot_20230813_121021](https://github.com/jaegertracing/jaeger/assets/140232061/602074bc-7285-48ee-97bf-ea5f0e21a586) ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Harish Shan <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
## Which problem is this PR solving? - Move to next Go version per maintenance policy (see #4653) ## Description of the changes Ran the script ```shell $ ./scripts/check-go-version.sh -u go.mod Go version: 1.20 docker/Makefile Go version: 1.20 *** => 1.21 *** .github/workflows/fossa.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-release.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-unit-tests.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-docker-build.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-build-binaries.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-crossdock.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-elasticsearch.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-grpc-badger.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-hotrod.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-protogen-tests.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-all-in-one-build.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-cassandra.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-opensearch.yml Go version: 1.20 *** => 1.21 *** .github/workflows/ci-kafka.yml Go version: 1.20 *** => 1.21 *** .golangci.yml Go version: 1.20 15 file(s) updated. ``` Signed-off-by: Yuri Shkuro <[email protected]>
Follow up to #4329.
scripts/check-go-version.sh
that verifies that all our build scripts are using the same Go version N, but go.mod is N-1. This includes GH actions, Alpine images, etc.scripts/update-go-version.sh
that updates those scripts to another version, to make these upgrades easier in the future (see Add shell script to ensure consistent version of OTEL semconv #4652 for reference). It should also bump go.mod to N-1.Version Compatibility Guarantees
) explaining the policy. For reference: https://github.com/open-telemetry/opentelemetry-collector#compatibilitySince Go 1.21 is out, this is an opportunity to test this new process.
The text was updated successfully, but these errors were encountered: