-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Do we want to make policy to support N-1 Go version? #4329
Comments
@jaegertracing/jaeger-maintainers can I get opinions? |
I agree for Jaeger to stay compatible with the N-1 Go version given that's the common practice in the Go community. +1 for CI check.
I don't have a strong opinion on this. I would slightly lean towards making this policy effective from the next Go version, unless if staying on 1.20 is causing significant problems for the OTEL collector. |
Can you confirm whether the policy will be in place following go 1.20? This means the collector dependencies on jaeger will at 1.41 until the collector bumps the version of go it supports. |
confirmed |
Go 1.21 is out, we will be dropping support for Go 1.19 (see open-telemetry/opentelemetry-collector-contrib/issues/25116 for status on this) and the new Jaeger policy will allow us to keep updating Jaeger after this |
Booked #4653 to track implementation of the policy |
@mx-psi @codeboten fyi #4724 |
Requirement
OpenTelemetry Collector has a policy of being compatible with the last two versions of Go, as common in the Go community.
Since Jaeger code is being imported in OTEL in some places, should we have a similar policy?
Problem
Our recent Go 1.20 upgrade (#4202) broke them since we started depending on Go 1.20 features.
Proposal
Open questions
The text was updated successfully, but these errors were encountered: