Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Do we want to make policy to support N-1 Go version? #4329

Closed
yurishkuro opened this issue Mar 22, 2023 · 7 comments
Closed

[Feature]: Do we want to make policy to support N-1 Go version? #4329

yurishkuro opened this issue Mar 22, 2023 · 7 comments

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Mar 22, 2023

Requirement

OpenTelemetry Collector has a policy of being compatible with the last two versions of Go, as common in the Go community.
Since Jaeger code is being imported in OTEL in some places, should we have a similar policy?

Problem

Our recent Go 1.20 upgrade (#4202) broke them since we started depending on Go 1.20 features.

Proposal

  • We can upgrade our CI to use new versions of Go when they come out
  • But our go.mod would stay on N-1 version to ensure compiler compatibility
  • We should enforce that with a CI check

Open questions

  • If we do this now, what do we do with incompatible changes, roll them back? Or make the policy effective from the next Go version only?
@yurishkuro
Copy link
Member Author

@jaegertracing/jaeger-maintainers can I get opinions?

@albertteoh
Copy link
Contributor

I agree for Jaeger to stay compatible with the N-1 Go version given that's the common practice in the Go community.

+1 for CI check.

If we do this now, what do we do with incompatible changes, roll them back? Or make the policy effective from the next Go version only?

I don't have a strong opinion on this. I would slightly lean towards making this policy effective from the next Go version, unless if staying on 1.20 is causing significant problems for the OTEL collector.

@codeboten
Copy link
Contributor

Can you confirm whether the policy will be in place following go 1.20? This means the collector dependencies on jaeger will at 1.41 until the collector bumps the version of go it supports.

@yurishkuro
Copy link
Member Author

confirmed

@mx-psi
Copy link
Contributor

mx-psi commented Aug 9, 2023

Go 1.21 is out, we will be dropping support for Go 1.19 (see open-telemetry/opentelemetry-collector-contrib/issues/25116 for status on this) and the new Jaeger policy will allow us to keep updating Jaeger after this

@yurishkuro
Copy link
Member Author

Booked #4653 to track implementation of the policy

@yurishkuro
Copy link
Member Author

@mx-psi @codeboten fyi #4724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants