Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Migrate to go 1.20 #4202

Closed
scalalang2 opened this issue Feb 2, 2023 · 4 comments · Fixed by #4206
Closed

[Feature]: Migrate to go 1.20 #4202

scalalang2 opened this issue Feb 2, 2023 · 4 comments · Fixed by #4206
Labels
enhancement

Comments

@scalalang2
Copy link

Requirement

Go 1.20 officially released today
There's improvements on the garbage collector. It informs that its overall performace improves by up to 2% and reduces memory overheads. I guess that migrating to go 1.20 will provides improved performance, bug fixes, security enhancements and etc.

Problem

There's no problem on Jaeger.
This proposal only include a simple suggestion.

Thanks.

Proposal

Migrate to go runtime 1.20.

Open questions

No response
@yurishkuro
Copy link
Member

Files to change:

$ grep -r 1.19 .
./go.mod:3:go 1.19
./docker/Makefile:4:GOLANG_IMAGE := golang:1.19-alpine
./.golangci.yml:2:  go: '1.19'
./.golangci.yml:30:    go: "1.19"
./.github/workflows/fossa.yml:28:          go-version: 1.19.x
./.github/workflows/ci-release.yml:34:        go-version: 1.19.x
./.github/workflows/ci-unit-tests.yml:33:        go-version: 1.19.x
./.github/workflows/ci-docker-build.yml:34:        go-version: 1.19.x
./.github/workflows/ci-build-binaries.yml:51:        go-version: 1.19.x
./.github/workflows/ci-crossdock.yml:34:        go-version: 1.19.x
./.github/workflows/ci-elasticsearch.yml:46:        go-version: 1.19.x
./.github/workflows/ci-grpc-badger.yml:27:        go-version: 1.19.x
./.github/workflows/ci-hotrod.yml:33:        go-version: 1.19.x
./.github/workflows/ci-protogen-tests.yml:29:        go-version: 1.19.x
./.github/workflows/ci-all-in-one-build.yml:33:        go-version: 1.19.x
./.github/workflows/ci-cassandra.yml:39:        go-version: 1.19.x
./.github/workflows/ci-opensearch.yml:43:        go-version: 1.19.x
./.github/workflows/ci-kafka.yml:27:        go-version: 1.19.x

SaarthakMaini added a commit to SaarthakMaini/jaeger that referenced this issue Feb 4, 2023
@SaarthakMaini
Updated Go Version from 1.19 to 1.20
5601067 
In this commit, all the files mentioned in issue jaegertracing#4202 have been updated
with Go version 1.20 replacing version 1.19
SaarthakMaini added a commit to SaarthakMaini/jaeger that referenced this issue Feb 4, 2023
@SaarthakMaini
Updated Go Version from 1.19 to 1.20
78f4f84 
All the files mentioned in issue jaegertracing#4202 have been updated with Go version
1.20 replacing version 1.19
Signed-off-by: Saarthak Maini <[email protected]>
@SaarthakMaini SaarthakMaini mentioned this issue Feb 4, 2023
Merged
SaarthakMaini added a commit to SaarthakMaini/jaeger that referenced this issue Feb 4, 2023
@SaarthakMaini
Updated Go Version from 1.19 to 1.20
8e48e04 
All the files mentioned in issue jaegertracing#4202 have been updated with Go version
1.20 replacing version 1.19

Signed-off-by: Saarthak <[email protected]>
@SaarthakMaini
Copy link
Contributor

PR for the issue has already been made and would be merged during the next Release Cycle.

@scalalang2
Copy link
Author

👍

yurishkuro added a commit that referenced this issue Mar 4, 2023
@SaarthakMaini @yurishkuro
Update Go version to 1.20 (#4206)
1d3bc1d 
## Which problem is this PR solving?
- Resolves #4202 

## Short description of the changes
All the files mentioned in issue #4202 have been updated with Go version
1.20 replacing version 1.19

Signed-off-by: Saarthak Maini <[email protected]>

---------

Signed-off-by: Saarthak <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this issue Mar 5, 2023
@SaarthakMaini @yurishkuro @shubbham1215
Update Go version to 1.20 (jaegertracing#4206)
ec3d83e 
## Which problem is this PR solving?
- Resolves jaegertracing#4202

## Short description of the changes
All the files mentioned in issue jaegertracing#4202 have been updated with Go version
1.20 replacing version 1.19

Signed-off-by: Saarthak Maini <[email protected]>

---------

Signed-off-by: Saarthak <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: shubbham1215 <[email protected]>
@mx-psi mx-psi mentioned this issue Mar 22, 2023
Closed
@mx-psi
Copy link
Contributor

mx-psi commented Mar 22, 2023 •
edited
Loading

I opened #4328 to suggest partially reverting the changes on #4206 so that Jaeger remains compatible with Go 1.19 as a library. This would help the OpenTelemetry Collector project, which aims to be compatible with all officially supported Go versions.

Note that after my PR binaries would still be built with Go 1.20 which I think would fulfill the goals that @scalalang2 talks about in this issue, this is only about using Jaeger as a library.

Please consider my PR! :)

@yurishkuro yurishkuro mentioned this issue Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Go version to 1.20 SaarthakMaini/jaeger
4 participants
@scalalang2 @yurishkuro @mx-psi @SaarthakMaini