Fix trace scoped links not supporting numeric fields #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns "For traces, the supported template fields are: duration, endTime, startTime, traceName and traceID." Fixes jaegertracing#465 Signed-off-by: Will Tran <[email protected]>
william-tran
force-pushed
the
fix-trace-scoped-links
branch
from
b6a70dc
to
a4c13f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 92.97% 92.93% -0.05%
==========================================
Files 197 197
Lines 4840 4840
Branches 1174 1174
==========================================
- Hits 4500 4498 -2
- Misses 300 302 +2
Partials 40 40
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Mar 5, 2020
everett980
approved these changes
Mar 6, 2020
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns "For traces, the supported template fields are: duration, endTime, startTime, traceName and traceID." Fixes jaegertracing#465 Signed-off-by: Will Tran <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns
"For traces, the supported template fields are: duration, endTime,
startTime, traceName and traceID."
Fixes #465
Signed-off-by: Will Tran [email protected]
Which problem is this PR solving?
Short description of the changes
typeof