Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trace-scoped external links similar to tag links #465

Closed
yurishkuro opened this issue Oct 13, 2019 · 3 comments · Fixed by #480 or #538
Closed

Support trace-scoped external links similar to tag links #465

yurishkuro opened this issue Oct 13, 2019 · 3 comments · Fixed by #480 or #538
Labels
enhancement good first issue hacktoberfest help wanted

Comments

@yurishkuro
Copy link
Member

Currently Jaeger allows to configure custom external links using Link Patterns (https://www.jaegertracing.io/docs/1.14/frontend-ui/#link-patterns).

@rwkarg asked for similar links at the trace level:

to link out to Kibana to view telemetry events for the current Trace (from the Trace view)
@rubenvp8510 rubenvp8510 mentioned this issue Nov 7, 2019
Merged
@yurishkuro
Copy link
Member Author

@rubenvp8510 could you please create a PR for documentation?

https://www.jaegertracing.io/docs/latest/frontend-ui/

@yurishkuro yurishkuro reopened this Dec 13, 2019
@rubenvp8510
Copy link
Collaborator

@yurishkuro sorry I forgot it, I'll create one.

@william-tran
Copy link
Contributor

I've found a bug: only traceID and traceName are usable as keys. PR coming shortly.

william-tran pushed a commit to autonomic-ai/jaeger-ui that referenced this issue Mar 5, 2020
Fix trace scoped links not supporting numeric fields
b6a70dc 
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns

"For traces, the supported template fields are: duration, endTime,
startTime, traceName and traceID."

Fixes jaegertracing#465

Signed-off-by: Will Tran <[email protected]>
@william-tran william-tran mentioned this issue Mar 5, 2020
Merged
william-tran pushed a commit to autonomic-ai/jaeger-ui that referenced this issue Mar 5, 2020
Fix trace scoped links not supporting numeric fields
a4c13f1 
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns

"For traces, the supported template fields are: duration, endTime,
startTime, traceName and traceID."

Fixes jaegertracing#465

Signed-off-by: Will Tran <[email protected]>
everett980 pushed a commit that referenced this issue Mar 6, 2020
Fix trace scoped links not supporting numeric fields (#538)
0882bde 
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns

"For traces, the supported template fields are: duration, endTime,
startTime, traceName and traceID."

Fixes #465

Signed-off-by: Will Tran <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
Fix trace scoped links not supporting numeric fields (jaegertracing#538)
9b3e43d 
From https://www.jaegertracing.io/docs/1.17/frontend-ui/#link-patterns

"For traces, the supported template fields are: duration, endTime,
startTime, traceName and traceID."

Fixes jaegertracing#465

Signed-off-by: Will Tran <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@yurishkuro yurishkuro mentioned this issue Oct 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
3 participants
@william-tran @yurishkuro @rubenvp8510