Fix #523 - Arrows are huge on Chrome Canary (Time sensitive) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
+ Coverage 92.87% 92.89% +0.02%
==========================================
Files 197 197
Lines 4814 4814
Branches 1162 1162
==========================================
+ Hits 4471 4472 +1
+ Misses 302 301 -1
Partials 41 41
Continue to review full report at Codecov.
|
|
@tiffon nice catch |
|
As far as I'm aware, yes it should be fine.
… |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…ng#524) Signed-off-by: Joe Farro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be worth releasing this fix as a patch.
#523 affects Chrome Canary which is version
Version 81.0.4023.0 (Official Build) canary (64-bit)(on my machine).Chrome is scheduled to update to version 81 on March 17th (see Chrome Platform Status).
When that happens, probably the current and all prior releases of Jaeger UI will have huge arrows on trace diffs, trace graph and ddg graphs.
Which problem is this PR solving?
Fixes #523 Plexus arrows are huge on Chrome Canary
Before
After
Short description of the changes
Change
markerUnitsin arrow definitions.