Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plexus arrows are huge on Chrome Canary #523

Closed
tiffon opened this issue Feb 18, 2020 · 1 comment · Fixed by #524
Closed

Plexus arrows are huge on Chrome Canary #523

tiffon opened this issue Feb 18, 2020 · 1 comment · Fixed by #524
Assignees
@tiffon
Labels
bug

Comments

@tiffon
Copy link
Member

tiffon commented Feb 18, 2020

Requirement - what kind of business use case are you trying to solve?

Usable node-link diagrams / graphs.

Problem - what in Jaeger blocks you from solving the requirement?

In latest version of Chrome Canary (Version 81.0.4023.0 (Official Build) canary (64-bit)) arrows on plexus edges are huge.

Before

Screen Shot 2020-02-18 at 5 25 04 am

Latest Chrome Canary

Screen Shot 2020-02-18 at 5 25 41 am

Proposal - what do you suggest to solve the problem or improve the existing situation?

Change markerUnits on the arrow definition to not be strokeWidth.

Any open questions to address

N/A
@tiffon tiffon added the bug label Feb 18, 2020
@tiffon tiffon self-assigned this Feb 18, 2020
tiffon added a commit to tiffon/jaeger-ui that referenced this issue Feb 18, 2020
@tiffon
Fix jaegertracing#523 - Arrows are huge on Chrome Canary
4d74339 
Signed-off-by: Joe Farro <[email protected]>
This was referenced Feb 18, 2020
Merged
Closed
@tiffon
Copy link
Member Author

tiffon commented Feb 18, 2020

Adding a screenshot of the issue showing a trace diff of HotROD traces.

Screen Shot 2020-02-18 at 6 11 10 am

everett980 pushed a commit that referenced this issue Feb 21, 2020
@tiffon
Fix #523 - Arrows are huge on Chrome Canary (#524)
fff092f 
Signed-off-by: Joe Farro <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@tiffon
Fix jaegertracing#523 - Arrows are huge on Chrome Canary (jaegertraci…
22eee0f 
…ng#524)

Signed-off-by: Joe Farro <[email protected]>

Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiffon tiffon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #523 - Arrows are huge on Chrome Canary (Time sensitive) tiffon/jaeger-ui
1 participant
@tiffon