Convert storage type to typed string

[SezalAgrawal]

The JaegerStorageSpec currently has the storage type as a string. It is changed to a typed string. This PR also includes changes in storage type in all the required files.

Resolves: #111
Signed-off-by: Sezal Agrawal [email protected]

[SezalAgrawal]

@jpkrohling I ran make generate and have committed the new zz_generated.openapi.go. The build is still failing with error message Build failed: a model has been changed but the generated resources aren't up to date. Run 'make generate' and update your PR.

[jpkrohling]

This looks like a path issue: take a look at the changes for the generated openapi, GetOpenAPIDefinitions function. Do you have a GOPATH set?

[codecov]

Codecov Report

Merging #1282 into master will increase coverage by 0.01%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master    #1282      +/-   ##
==========================================
+ Coverage   87.31%   87.32%   +0.01%     
==========================================
  Files          90       89       -1     
  Lines        4942     4947       +5     
==========================================
+ Hits         4315     4320       +5     
  Misses        464      464              
  Partials      163      163              

Impacted Files	Coverage Δ
pkg/storage/elasticsearch_secrets.go	89.85% <ø> (ø)
pkg/cronjob/spark_dependencies.go	93.00% <75.00%> (ø)
pkg/apis/jaegertracing/v1/jaeger_types.go	100.00% <100.00%> (ø)
pkg/deployment/all_in_one.go	100.00% <100.00%> (ø)
pkg/deployment/collector.go	96.50% <100.00%> (ø)
pkg/deployment/ingester.go	95.90% <100.00%> (ø)
pkg/deployment/query.go	100.00% <100.00%> (ø)
pkg/storage/dependency.go	100.00% <100.00%> (ø)
pkg/storage/elasticsearch.go	81.20% <100.00%> (ø)
pkg/storage/elasticsearch_dependencies.go	100.00% <100.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f2540...5c919e3. Read the comment docs.

[kevinearls]

LGTM

[jpkrohling]

Marking this as approved based on @kevinearls's review.

[jpkrohling]

Thank you for your contribution!