Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert storage type to typed string #111

Closed
jpkrohling opened this issue Nov 12, 2018 · 3 comments · Fixed by #1282
Closed

Convert storage type to typed string #111

jpkrohling opened this issue Nov 12, 2018 · 3 comments · Fixed by #1282
Assignees
@SezalAgrawal
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Contributor

The JaegerStorageSpec currently has the storage type as a string:

jaeger-operator/pkg/apis/io/v1alpha1/types.go

Line 111 in 02ba08a

Type string `json:"type"` // can be `memory` (default), `cassandra`, `elasticsearch`, `kafka` or `managed`

It would be better to have a typed string like we have for the IngressSecurityType:

jaeger-operator/pkg/apis/io/v1alpha1/types.go

Lines 8 to 26 in 02ba08a

// IngressSecurityType represents the possible values for the security type
type IngressSecurityType string
const (
// FlagPlatformKubernetes represents the value for the 'platform' flag for Kubernetes
FlagPlatformKubernetes = "kubernetes"
// FlagPlatformOpenShift represents the value for the 'platform' flag for OpenShift
FlagPlatformOpenShift = "openshift"
// IngressSecurityNone disables any form of security for ingress objects (default)
IngressSecurityNone IngressSecurityType = ""
// IngressSecurityNoneExplicit used when the user specifically set it to 'none'
IngressSecurityNoneExplicit IngressSecurityType = "none"
// IngressSecurityOAuthProxy represents an OAuth Proxy as security type
IngressSecurityOAuthProxy IngressSecurityType = "oauth-proxy"
)

jaeger-operator/pkg/apis/io/v1alpha1/types.go

Line 83 in 02ba08a

Security IngressSecurityType `json:"security"`

@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers labels Nov 12, 2018
@objectiser
Copy link
Contributor

Only thing to consider is whether this would cause a problem if we have a more decoupled plugin model?

@jpkrohling jpkrohling added needs-triage New issues, in need of classification and removed needs-triage New issues, in need of classification labels Dec 16, 2019
@jpkrohling jpkrohling mentioned this issue Feb 25, 2020
Open
@SezalAgrawal
Copy link
Contributor

Can I pick this task?

@jpkrohling
Copy link
Contributor Author

It's yours!

SezalAgrawal added a commit to SezalAgrawal/jaeger-operator that referenced this issue Oct 28, 2020
@SezalAgrawal
Convert storage type to typed string
c95d777 
Changed references of storage type throughout the repo.

Resolves: jaegertracing#111
Signed-off-by: Sezal Agrawal <[email protected]>
@SezalAgrawal SezalAgrawal mentioned this issue Oct 28, 2020
Merged
@mergify mergify bot closed this as completed in #1282 Oct 29, 2020
mergify bot pushed a commit that referenced this issue Oct 29, 2020
@SezalAgrawal
Convert storage type to typed string (#1282)
c418931 
The JaegerStorageSpec currently has the storage type as a string. It is changed to a typed string. This PR also includes changes in storage type in all the required files.

Resolves: #111
Signed-off-by: Sezal Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SezalAgrawal SezalAgrawal

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert storage type to typed string SezalAgrawal/jaeger-operator
3 participants
@jpkrohling @objectiser @SezalAgrawal