-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcodeTargetsManualConfig #582
Conversation
brunobowden
commented
Jan 10, 2016
- Manual config mode for Xcode targets in Podfile
- FAQ to explain how to use this
- Better "DO NOT MODIFY" lines for "pod method" + upgrade logic
- Fixes Config to only add j2objc_shared method to Podfile and not update targets #561
- Fixes Process or reject more complex Podfile situations #562
e97f30b
to
26089a8
Compare
hi. I looked through the code and it looks good to me. I think I tried to handle some more edge cases, like if there already is an empty line before the line where to insert the methods, don't add a second empty line and on where to insert new pod methods. But you are right that this is more robust now. |
Thanks @saruye, please take a closer look. When I'm writing that much code, I'm sure that I've made some mistakes and I'm not confident until some flaws have been discovered ;-) Likely the presentation will be recorded and posted online. The build is failing on OS X due to the Btw, the old method you had before of
That'll add in all the |
b503a60
to
0d7a5c4
Compare
- Manual config mode for Xcode targets in Podfile - FAQ to explain how to use this - Better "DO NOT MODIFY" lines for "pod method" + upgrade logic - Fixes j2objc-contrib#561 - Fixes j2objc-contrib#562
@saruye - v0.6.0 of the plugin has been published, please try this out and report back any issues |
I didn't find time yet to look at it again :/ sry. will test it on the weekend! |